<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 7, 2016 at 11:37 PM, Chris Angelico <span dir="ltr"><<a href="mailto:rosuav@gmail.com" target="_blank">rosuav@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, Oct 8, 2016 at 8:31 AM, Maciej Szulik <<a href="mailto:soltysh@gmail.com">soltysh@gmail.com</a>> wrote:<br>
> There's one nit with that cherry-pick, it already creates the commit, and<br>
> current<br>
> description states you should create a commit after running tests [1].<br>
><br>
</span>> [1]<br>
> <a href="http://cpython-devguide.readthedocs.io/en/github/committing.html#merging-between-different-branches-within-the-same-major-version" rel="noreferrer" target="_blank">http://cpython-devguide.<wbr>readthedocs.io/en/github/<wbr>committing.html#merging-<wbr>between-different-branches-<wbr>within-the-same-major-version</a><br>
<br>
Not sure that that need be a problem. You've already run the tests on<br>
the other branch, presumably, so the chances of a test failure are<br>
low; most of the time, it'll be "cherry-pick, test, push", and very<br>
occasionally, it'll be "cherry-pick, test, oops failures, reset or<br>
amend". As long as you don't push, there's nothing permanent in the<br>
commit.<br></blockquote><div><br></div><div>Totally agree, that's why I went with that change and left the history behind.<br></div><div>But run tests is still required :)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
ChrisA<br>
______________________________<wbr>_________________<br>
core-workflow mailing list<br>
<a href="mailto:core-workflow@python.org">core-workflow@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/core-workflow" rel="noreferrer" target="_blank">https://mail.python.org/<wbr>mailman/listinfo/core-workflow</a><br>
This list is governed by the PSF Code of Conduct: <a href="https://www.python.org/psf/codeofconduct" rel="noreferrer" target="_blank">https://www.python.org/psf/<wbr>codeofconduct</a><br>
</div></div></blockquote></div><br></div></div>