<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, 9 Feb 2017 at 14:20 Zachary Ware <<a href="mailto:zachary.ware%2Bpydev@gmail.com">zachary.ware+pydev@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Feb 9, 2017 at 2:12 PM, Brett Cannon <<a href="mailto:brett@python.org" class="gmail_msg" target="_blank">brett@python.org</a>> wrote:<br class="gmail_msg">
> OK, executive decision: let's test a rewrite but only for things that match<br class="gmail_msg">
> the regex at the beginning of the commit message (using Senthil's long list<br class="gmail_msg">
> of possible formats so we get "bpo-NNNN" and not "Issue bpo-NNNN"). That<br class="gmail_msg">
> won't have any false-positives and still gets us consistent issue naming for<br class="gmail_msg">
> the whole repo (at least in the commit summary line, but that will also act<br class="gmail_msg">
> as a scope to the commit that any ambiguous "#NNNN" numbers apply to bpo).<br class="gmail_msg">
> If this test doesn't lead to people being happy we will abandon the idea of<br class="gmail_msg">
> any history rewriting for tomorrow.<br class="gmail_msg">
<br class="gmail_msg">
Note that matching only the beginning of the message will miss several<br class="gmail_msg">
recent commits like:<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://hg.python.org/cpython/rev/7b8df4a5d81d" rel="noreferrer" class="gmail_msg" target="_blank">https://hg.python.org/cpython/rev/7b8df4a5d81d</a><br class="gmail_msg">
<a href="https://hg.python.org/cpython/rev/31342913fb1e" rel="noreferrer" class="gmail_msg" target="_blank">https://hg.python.org/cpython/rev/31342913fb1e</a><br class="gmail_msg">
<a href="https://hg.python.org/cpython/rev/37705f89c72b" rel="noreferrer" class="gmail_msg" target="_blank">https://hg.python.org/cpython/rev/37705f89c72b</a></blockquote><div><br></div><div>Beginning of line would catch these, so using re.MULTILINE would cover those.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg">
<br class="gmail_msg">
There is also the issue of multiple issue numbers in a message:<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://hg.python.org/cpython/rev/a5538734cc87" rel="noreferrer" class="gmail_msg" target="_blank">https://hg.python.org/cpython/rev/a5538734cc87</a><br class="gmail_msg">
<a href="https://hg.python.org/cpython/rev/ffc0840762e4" rel="noreferrer" class="gmail_msg" target="_blank">https://hg.python.org/cpython/rev/ffc0840762e4</a></blockquote><div><br></div><div>Yep, this will never be perfect, hence it's either best-effort or we simply don't do it. </div></div></div>