
<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 22, 2017, at 11:17 PM, Nick Coghlan <<a href="mailto:ncoghlan@gmail.com" class="">ncoghlan@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On 23 February 2017 at 02:25, Barry Warsaw <<a href="mailto:barry@python.org" class="">barry@python.org</a>> wrote:<br class=""><blockquote type="cite" class="">On Feb 22, 2017, at 11:10 AM, Donald Stufft wrote:<br class=""><br class=""><blockquote type="cite" class="">FWIW, I don’t think that creating a new PR and closing the original one is a<br class="">subpar experience for contributors, particularly if we turn off the bit that<br class="">requires reviews and just turn on the thing that requires passing<br class="">tests. Having been in that situation it has never once bothered me to have<br class="">someone cherry pick my change and amend it.<br class=""></blockquote><br class="">Since we're squashing commits wouldn't that obliterate the original author's<br class="">credit for the work?<br class=""></blockquote><br class="">You can set "--author" when making the new squash commit (we should<br class="">document that somewhere, since it's also useful when importing patches<br class="">from <a href="http://bugs.python.org" class="">bugs.python.org</a>).<br class=""><br class="">Although looking at <a href="https://github.com/python/cpython/pull/169" class="">https://github.com/python/cpython/pull/169</a> (where<br class="">I set the author to Serhiy, since I was importing a patch he wrote),<br class="">it seems GitHub doesn't actually *show* the Author information<br class="">anywhere that I can find.<br class=""><br class=""></div></div></blockquote><br class=""></div><div><br class=""></div><div>Github automatically sets author of the squash commit based on who opened the PR.</div><br class=""><div class="">

<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class="">—<br class="">Donald Stufft<br class=""></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div><br class="Apple-interchange-newline">

</div>

<br class=""></body></html>