<div dir="ltr">Two things. One, has someone verified that if a core dev edits a PR that the squash commit still gives the PR creator the author credit in the git metadata? I remember doing an edit like this once and GitHub didn't show any author credit in the web UI because I assume GitHub refused to guess who the author credit should go to. So if someone could test this in a checkout that would be great as that means <a href="https://github.com/python/core-workflow/issues/7">https://github.com/python/core-workflow/issues/7</a> can be easily solved and we can automate Misc/ACKS.<div><br></div><div>Two, we are going to review the new workflow in two weeks after having been using it for a month (I can't believe it's only been two weeks since the migration!). Since the sign-off requirement has generated the most discussion, what I will do is swap the requirement for PR merging to be no required review but to require all-green status checks (in a previous email Donald alluded to the fact that I thought self-approval would be possible in "emergencies" but that obviously doesn't hold). This will give us basically 2 weeks with both approaches when we review the process so we can make an informed decision.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, 22 Feb 2017 at 20:19 Donald Stufft <<a href="mailto:donald@stufft.io">donald@stufft.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Feb 22, 2017, at 11:17 PM, Nick Coghlan <<a href="mailto:ncoghlan@gmail.com" class="gmail_msg" target="_blank">ncoghlan@gmail.com</a>> wrote:</div><br class="m_9020685471222125980Apple-interchange-newline gmail_msg"><div class="gmail_msg"><div class="gmail_msg">On 23 February 2017 at 02:25, Barry Warsaw <<a href="mailto:barry@python.org" class="gmail_msg" target="_blank">barry@python.org</a>> wrote:<br class="gmail_msg"><blockquote type="cite" class="gmail_msg">On Feb 22, 2017, at 11:10 AM, Donald Stufft wrote:<br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg">FWIW, I don’t think that creating a new PR and closing the original one is a<br class="gmail_msg">subpar experience for contributors, particularly if we turn off the bit that<br class="gmail_msg">requires reviews and just turn on the thing that requires passing<br class="gmail_msg">tests. Having been in that situation it has never once bothered me to have<br class="gmail_msg">someone cherry pick my change and amend it.<br class="gmail_msg"></blockquote><br class="gmail_msg">Since we're squashing commits wouldn't that obliterate the original author's<br class="gmail_msg">credit for the work?<br class="gmail_msg"></blockquote><br class="gmail_msg">You can set "--author" when making the new squash commit (we should<br class="gmail_msg">document that somewhere, since it's also useful when importing patches<br class="gmail_msg">from <a href="http://bugs.python.org" class="gmail_msg" target="_blank">bugs.python.org</a>).<br class="gmail_msg"><br class="gmail_msg">Although looking at <a href="https://github.com/python/cpython/pull/169" class="gmail_msg" target="_blank">https://github.com/python/cpython/pull/169</a> (where<br class="gmail_msg">I set the author to Serhiy, since I was importing a patch he wrote),<br class="gmail_msg">it seems GitHub doesn't actually *show* the Author information<br class="gmail_msg">anywhere that I can find.<br class="gmail_msg"><br class="gmail_msg"></div></div></blockquote><br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg"></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">Github automatically sets author of the squash commit based on who opened the PR.</div><br class="gmail_msg"><div class="gmail_msg">
<div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><br class="gmail_msg">—</div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><br class="gmail_msg">Donald Stufft<br class="gmail_msg"></div></div></div>_______________________________________________<br class="gmail_msg">
core-workflow mailing list<br class="gmail_msg">
<a href="mailto:core-workflow@python.org" class="gmail_msg" target="_blank">core-workflow@python.org</a><br class="gmail_msg">
<a href="https://mail.python.org/mailman/listinfo/core-workflow" rel="noreferrer" class="gmail_msg" target="_blank">https://mail.python.org/mailman/listinfo/core-workflow</a><br class="gmail_msg">
This list is governed by the PSF Code of Conduct: <a href="https://www.python.org/psf/codeofconduct" rel="noreferrer" class="gmail_msg" target="_blank">https://www.python.org/psf/codeofconduct</a></blockquote></div></div></div>