<div dir="auto">WRT the return value, I don't really care. But I am strongly in favor of removing the build_dir option as I think that the entire premise is wrong. During development, you want to use an editable install, which does modify the source tree. And if you're just installing, then you don't care about cache. And there is also nothing preventing pip from caching the temporary directory, which may contain build artifacts.</div><div class="gmail_extra"><br><div class="gmail_quote">On Aug 24, 2017 8:41 AM, "xoviat" <<a href="mailto:xoviat@gmail.com">xoviat@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"></div><div class="gmail_quote">---------- Forwarded message ----------<br>From: "xoviat" <<a href="mailto:xoviat@gmail.com" target="_blank">xoviat@gmail.com</a>><br>Date: Aug 24, 2017 8:39 AM<br>Subject: Re: [Distutils] PEP 517 again<br>To: "Thomas Kluyver" <<a href="mailto:thomas@kluyver.me.uk" target="_blank">thomas@kluyver.me.uk</a>><br>Cc: <br><br type="attribution"><div dir="auto">That's actually the general argument against exceptions and why golang doesn't have them. I have not seen notimplemented used in the wild ever though.<div dir="auto"><br></div><div dir="auto">Also, regarding the build_dir argument, it won't be used in pip. The pip devs may have said that but it's too much work to support now and most of them seem to have a shortage of time. Pip will be copying to a temporary directory for a long time. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Aug 24, 2017 8:28 AM, "Thomas Kluyver" <<a href="mailto:thomas@kluyver.me.uk" target="_blank">thomas@kluyver.me.uk</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div><div>On Thu, Aug 24, 2017, at 02:21 PM, xoviat wrote:<br></div>
<blockquote type="cite"><div>I mean is this golang or Python? In Python, you raise notimplementederror.<br></div>
</blockquote><div><br></div>
<div>But there's a NotImplemented singleton in Python as well. The argument for using a return value is that the hook code has to deliberately return that, whereas a NotImplementedError could bubble up from some internal call, in which case it should really be registered as an error.<br></div>
</div>
</blockquote></div></div>
</div>
</blockquote></div></div>