<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Hey John, this looks nifty! However, I have a few comments for how it can be improved:</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">* You should use the “cryptography” module instead of PyOpenSSL: <a href="https://cryptography.io">https://cryptography.io</a></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">* None of your classes or methods have docstrings! I suggest writing docstrings, and using Sphinx’s autodoc extension to render those docstrings in your documentation: <a href="http://www.sphinx-doc.org/en/stable/ext/autodoc.html">http://www.sphinx-doc.org/en/stable/ext/autodoc.html</a> </div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">* What if I don’t want to use YAML? I suggest removing that dependency, and exposing an API to fetch a template. That way, the developer can put multiple templates in one YAML file the way you have it set up, but it’s not required, and if the developer doesn’t use YAML then it won’t be pulled in as a dependency.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">* ASK_VERIFY_TIMESTAMP is set to False by default, but it’s generally good practice to make code secure by default. That way, a developer can intentionally and knowingly change the defaults to be insecure for development purposes, but is less likely to leave them insecure in production.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">* Rather than setting a default ASK_ROUTE setting, why not construct this as a Flask Blueprint, so the developer can attach it to whatever URL he/she wants?</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Let me know if you’d like me to clarify some of these points. In spite of my comments, I think this is a really nifty idea, and I might want to try using it sometime!</div> <div id="bloop_sign_1463066510489714176" class="bloop_sign"></div><div id="bloop_sign_1463066510489714176" class="bloop_sign"><br></div><div id="bloop_sign_1463066510489714176" class="bloop_sign">David Baumgold</div> <br><p class="airmail_on">On May 12, 2016 at 11:12:41 AM, John Wheeler (<a href="mailto:jwheeler1@gmail.com">jwheeler1@gmail.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>
<title></title>
<div dir="ltr">Hello everybody out there,
<div><br></div>
<div>I've been working on a Flask extension, called Flask-Ask, for
programming Alexa skills on the Amazon Echo. I've been working on
this for a few weeks now and have a release pushed up to pypi,
samples, and documentation.</div>
<div><br></div>
<div>The Alexa service is based on its own request / response model
that uses JSON over HTTP. I made Flask-Ask's API similar to Flask's
in that regard with routing / parameter mapping, context locals,
and integration with Flask's template system.</div>
<div><br></div>
<div>The code and samples are available at</div>
<div><br></div>
<div><a href="https://github.com/johnwheeler/flask-ask">https://github.com/johnwheeler/flask-ask</a><br>
</div>
<div><br></div>
<div>The documentation is here</div>
<div><br></div>
<div><a href="http://flask-ask.readthedocs.io/en/latest/">http://flask-ask.readthedocs.io/en/latest/</a><br>
</div>
<div><br></div>
<div>I'd like to know what people think of the API and what
features they want. I'm working on a tutorial that shows how to
rapidly develop skills with Flask-Ask and <a href="http://ngrok.io">ngrok.io</a>, and I'm available for a Google
Hangout if you want to try and need help in the interim.</div>
<div><br></div>
<div>John</div>
</div>
_______________________________________________
<br>Flask mailing list
<br>Flask@python.org
<br>https://mail.python.org/mailman/listinfo/flask
<br></div></div></span></blockquote></body></html>