<br><br><div class="gmail_quote">On Wed, Jul 20, 2011 at 13:02, Eric Snow <span dir="ltr"><<a href="mailto:ericsnowcurrently@gmail.com">ericsnowcurrently@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Last night I had a chance to get started on an implementation for the<br>
PEP. I'm taking the importlib route. Before I do much more I wanted<br>
to check on a couple of things with this group.<br></blockquote><div><br>Obviously feel free to ask me questions (publicly or privately) if anything in the importlib code is an issue for you (I know its structure for bootstrapping reasons is a bit odd).<br>
<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
First of all, I don't want to go to much effort here if others are<br>
already focused on the implementation, particularly since I'm sure all<br>
of you would do a better job than I would. I already feel like I have<br>
butt in on the work Barry, Eric, and crew were getting started. <wink><br>
If someone is already going to take care of the implementation please<br>
let me know.<br></blockquote><div><br>I really doubt anyone has jumped into this as much as you have, Eric. =) You can also always do it on bitbucket or somewhere so that others can collaborate. I believe there is even a cpython mirror there so that should make it easy to fork and pull in updates.<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
In case you haven't noticed, Python is my first foray into an<br>
open-source project, and I've only been involved since the pycon<br>
sprints (been using Python exclusively for 5 years though). So, I am<br>
still feeling out the mechanics of how people cooperate on this sort<br>
of stuff.<br>
<br>
Secondly, regardless of importlib or import.c or whatever, the sys<br>
module will need to have "virtual_packages" added right? I stuck that<br>
code in import.c next to where sys.meta_path and others get<br>
initialized [1]. Is that the right place to do it? Should it go in<br>
sysmodule.c instead?<br></blockquote><div><br>I can understand populating those properties in import.c, but it is probably better to initialize the empty data structures in sysmodule.c so that the code to get the module in a basic state is centralized. but if sys.meta_path and friends are elsewhere then you can start there and have a separate patch (file a bug now, though) to possibly relocate the code later.<br>
<br>-Brett<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Thanks,<br>
<br>
-eric<br>
<br>
[1] <a href="http://hg.python.org/cpython/file/default/Python/import.c#l204" target="_blank">http://hg.python.org/cpython/file/default/Python/import.c#l204</a><br>
_______________________________________________<br>
Import-SIG mailing list<br>
<a href="mailto:Import-SIG@python.org">Import-SIG@python.org</a><br>
<a href="http://mail.python.org/mailman/listinfo/import-sig" target="_blank">http://mail.python.org/mailman/listinfo/import-sig</a><br>
</blockquote></div><br>