Sure, we can meet to look into it. If I recall correctly, I exactly followed the merge flow provided by github at the bottom of the pull request.<br><br><div class="gmail_quote">On Fri, Oct 22, 2010 at 10:59, Fernando Perez <span dir="ltr"><<a href="http://fperez.net">fperez.net</a>@<a href="http://gmail.com">gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On Fri, Oct 22, 2010 at 2:49 AM, Thomas Kluyver <<a href="mailto:takowl@gmail.com">takowl@gmail.com</a>> wrote:<br>
><br>
> A couple of other things strike me about it:<br>
> - In the ipython network graph on github, it doesn't show up as a merge<br>
> (there's no other branch leading into it). You have to scroll back a bit now<br>
> to see it, but it's the first in a cluster of three commits on trunk just<br>
> before the number 11 on the date line.<br>
> - Other merges usually mention branches in the commit message. This one just<br>
> mentions a file.<br>
><br>
> Perhaps Min can shed more light, if he remembers how he made the commit. It<br>
> does seem that something didn't go to plan. I've noticed a few places where<br>
> it's reverting to older forms of code (e.g. using exceptions.Exception), and<br>
> I've been tidying them up in my cleanup-old-code branch. I'll put in a pull<br>
> request.<br>
><br>
> If you're worried about possible regressions, I think the best thing is for<br>
> you and Min to go over the diff for that commit and work out which changes<br>
> were intentional.<br>
<br>
</div>Yes, I am worried. Min, let's try to get together sometime next week<br>
and do a little forensics on this one, to make sure nothing else<br>
slipped by. I'd also like to understand *what happened* so we don't<br>
repeat this in the future, but I admit I'm puzzled right now.<br>
<br>
Cheers,<br>
<font color="#888888"><br>
f<br>
</font></blockquote></div><br>