It ended up a bit more complicated; that patch leaks memory when a socket isn't closed manually. There's also an issue with how the close flag on _fileobject works -- rather than simply decrementing the refcount the way that socket.close does, it should close the socket regardless of the refcount.<br>
<br>
<div class="gmail_quote">On Tue, Jul 15, 2008 at 9:24 AM, Michael Foord <<a href="mailto:fuzzyman@voidspace.org.uk">fuzzyman@voidspace.org.uk</a>> wrote:<br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<div class="Ih2E3d">Curt Hagenlocher wrote:<br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Those changes will be in 2.0b4.<br> <br></blockquote></div>Is this your patch from March, added to the following work item?<br>
<br><a href="http://www.codeplex.com/IronPython/WorkItem/View.aspx?WorkItemId=10825" target="_blank">http://www.codeplex.com/IronPython/WorkItem/View.aspx?WorkItemId=10825</a><br><br>Michael<br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Some of CPython's socket tests are problematic in the face of non-deterministic finalization. They assume, for instance, that a socket will implicitly be closed when the variable goes out of scope. Because of this, and because users haven't had a chance to bang on them yet, I wasn't confident enough in the changes I made to advocate porting them back to <a href="http://1.1.2./" target="_blank">1.1.2.</a> <<a href="http://1.1.0.2/" target="_blank">http://1.1.2</a>.>
<div class="Ih2E3d"><br><br>On Tue, Jul 15, 2008 at 8:38 AM, Michael Foord <<a href="mailto:fuzzyman@voidspace.org.uk" target="_blank">fuzzyman@voidspace.org.uk</a> <mailto:<a href="mailto:fuzzyman@voidspace.org.uk" target="_blank">fuzzyman@voidspace.org.uk</a>>> wrote:<br>
<br> Hello guys,<br><br> The only socket related issue I see in that list is:<br><br> 16356 1.1.2: socket.getnameinfo(...) broken under Vista<br><br> We were hoping that 1.1.2 would finally put to rest IronPython 1<br>
issues with urllib / urllib2. Has that been done?<br><br> All the best,<br><br> Michael<br><br> Srivatsn Narayanan wrote:<br><br><br> Hello IronPython Community,<br><br> I'm pleased to announce the release of IronPython 1.1.2 RC1.<br>
In this release twenty-one CodePlex work Items that were<br> identified as high priority on the IronPython mailing list<br> were fixed. It's worth noting that this included the<br> implementation of the "_winreg" CPython module and a few<br>
performance improvements in targeted areas. Please also note<br> that there are two potentially breaking changes in this release:<br><br> · nt.unlink will now throw an exception if the file doesn't<br>
exist, as it does in CPython.<br><br> · The signature of <a href="http://ironpython.runtime.operations.ops.id/" target="_blank">IronPython.Runtime.Operations.Ops.Id</a><br></div> <<a href="http://ironpython.runtime.operations.ops.id/" target="_blank">http://ironpython.runtime.operations.ops.id/</a>>() has changed
<div>
<div></div>
<div class="Wj3C7c"><br> and it now returns an object instead of long. This maps to the<br> id() function in python. Note that there is no change for<br> python caused by this and only code which is directly calling<br>
Ops.Id from a statically typed language like C# or VB will be<br> affected.<br><br> Assuming no major issues are discovered in this build, we hope<br> to rerelease it as our last planned IronPython 1.1 release,<br>
IronPython 1.1.2, in several weeks. Please let us know if you<br> encounter any issues as soon as possible.<br><br> The following CodePlex Work Items were closed:<br><br> · 16368 1.1.2: nt.access is missing<br>
<br> · 16402 1.1.2: implement _winreg module<br><br> · 15105 1.1.2: endpos is zero in IronPython 1.1.1<br><br> · 16335 1.1.2: Event handlers can cause circular references<br> and leak memory<br><br>
· 16337 1.1.2: Trivial: Implement float.__lt__(float)<br><br> · 16338 1.1.2: Using lambda in class definition will add<br> <lambda$..> into the<br><br> · 16342 1.1.2: calling base class __call__ invokes constructor<br>
instead<br><br> · 16343 1.1.2: problem with __slots__ and __init__ in<br> new-style classes<br><br> · 16347 1.1.2: Trivial: popen shouldn't open new window<br><br> · 16348 1.1.2: Removes the inexistent file did not throw<br>
OSError in IP<br><br> · 16350 1.1.2: int() doesn't convert representable longs to int<br><br> · 16351 1.1.2: dict.update doesn't take keyword arguments -<br> differs from CPython<br><br> · 16353 1.1.2: Trivial: int('0x20', 16) fails to parse, long too<br>
<br> · 16355 1.1.2: unpacking single element tuples in<br> for-statement, listcomp and generator<br><br> · 16356 1.1.2: socket.getnameinfo(...) broken under Vista<br><br> · 16360 1.1.2: Class with slots and getattr not compatible<br>
<br> · 16363 1.1.2: Can't call method w/ nullable as 1st argument<br> w/ greater than 5 arguments<br><br> · 16364 1.1.2: Backport fix for compiled regular expressions<br><br> · 16365 1.1.2: Tuple hashing improvements<br>
<br> · 16366 1.1.2: PyCF_DONT_IMPLY_DEDENT support in compile<br><br> · 16749 1.1.2 (Trivial): Modifier of<br> PythonEngine.DefaultCompilerContext(..)<br><br> We'd like to thank everyone in the community who contributed<br>
to these bugs: Ronnie Maor, jackeyoo, sanxiyn, Michael Foord,<br> Kamil Dworakowski, lthompson, romank, Jeff Brown, rridge,<br> David Fraser, pobrien, ebaklund.<br><br> You can download IronPython 1.1.2 RC1 at:<br>
<a href="http://www.codeplex.com/IronPython/Release/ProjectReleases.aspx?ReleaseId=15198" target="_blank">http://www.codeplex.com/IronPython/Release/ProjectReleases.aspx?ReleaseId=15198</a><br><br><br> The IronPython Team<br>
<br> ------------------------------------------------------------------------<br><br> _______________________________________________<br> Users mailing list<br></div></div> <a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a> <mailto:<a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a>>
<div class="Ih2E3d"><br> <a href="http://lists.ironpython.com/listinfo.cgi/users-ironpython.com" target="_blank">http://lists.ironpython.com/listinfo.cgi/users-ironpython.com</a><br> <br><br><br> -- <a href="http://www.ironpythoninaction.com/" target="_blank">http://www.ironpythoninaction.com/</a><br>
<a href="http://www.voidspace.org.uk/" target="_blank">http://www.voidspace.org.uk/</a><br> <a href="http://www.trypython.org/" target="_blank">http://www.trypython.org/</a><br> <a href="http://www.ironpython.info/" target="_blank">http://www.ironpython.info/</a><br>
<a href="http://www.theotherdelia.co.uk/" target="_blank">http://www.theotherdelia.co.uk/</a><br> <a href="http://www.resolverhacks.net/" target="_blank">http://www.resolverhacks.net/</a><br><br> _______________________________________________<br>
Users mailing list<br></div> <a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a> <mailto:<a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a>>
<div class="Ih2E3d"><br> <a href="http://lists.ironpython.com/listinfo.cgi/users-ironpython.com" target="_blank">http://lists.ironpython.com/listinfo.cgi/users-ironpython.com</a><br><br><br>------------------------------------------------------------------------<br>
<br>_______________________________________________<br>Users mailing list<br><a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a><br><a href="http://lists.ironpython.com/listinfo.cgi/users-ironpython.com" target="_blank">http://lists.ironpython.com/listinfo.cgi/users-ironpython.com</a><br>
<br></div></blockquote>
<div>
<div></div>
<div class="Wj3C7c"><br><br>-- <br><a href="http://www.ironpythoninaction.com/" target="_blank">http://www.ironpythoninaction.com/</a><br><a href="http://www.voidspace.org.uk/" target="_blank">http://www.voidspace.org.uk/</a><br>
<a href="http://www.trypython.org/" target="_blank">http://www.trypython.org/</a><br><a href="http://www.ironpython.info/" target="_blank">http://www.ironpython.info/</a><br><a href="http://www.theotherdelia.co.uk/" target="_blank">http://www.theotherdelia.co.uk/</a><br>
<a href="http://www.resolverhacks.net/" target="_blank">http://www.resolverhacks.net/</a><br><br>_______________________________________________<br>Users mailing list<br><a href="mailto:Users@lists.ironpython.com" target="_blank">Users@lists.ironpython.com</a><br>
<a href="http://lists.ironpython.com/listinfo.cgi/users-ironpython.com" target="_blank">http://lists.ironpython.com/listinfo.cgi/users-ironpython.com</a><br></div></div></blockquote></div><br>