Yeah, I ran into an issue even with having the AppDomain.CurrentDomain.AssemblyResolve += ... in the same method as the call to PythonOps because it's at the beginning of the method that the runtime resolves the methods called, that's why I moved it to a static constructor.<br>
<br><div class="gmail_quote">On Thu, Feb 23, 2012 at 11:20 PM, Dino Viehland <span dir="ltr"><<a href="mailto:dinov@microsoft.com">dinov@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Forget that moving AssemblyResolve to PythonOps comment… chicken, egg, etc…
</span><span style="font-size:11.0pt;font-family:Wingdings;color:#1f497d">J</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><a name="135ae04633bc9f08__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> ironpython-users-bounces+dinov=<a href="mailto:microsoft.com@python.org" target="_blank">microsoft.com@python.org</a> [mailto:<a href="mailto:ironpython-users-bounces%2Bdinov" target="_blank">ironpython-users-bounces+dinov</a>=<a href="mailto:microsoft.com@python.org" target="_blank">microsoft.com@python.org</a>]
<b>On Behalf Of </b>Dino Viehland<br>
<b>Sent:</b> Thursday, February 23, 2012 10:16 PM<br>
<b>To:</b> Slide; <a href="mailto:ironpython-users@python.org" target="_blank">ironpython-users@python.org</a><br>
<b>Subject:</b> Re: [Ironpython-users] Patch<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This is awesome, a couple comments:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> Can AssemblyResolve be moved into PythonOps? It looks like it keys off of Assembly.GetEntryAssembly() and so doesn’t rely on anything in the
generated assembly. That’d make it easier to read and update the code. Maybe I missed something that depends upon the assembly, but if that’s the case the assembly could be passed into a class which has the AssemblyResolve method.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> I think the GlobalAssemblyCache check is too strong. Ipy install via the MSI will go into the GAC and so I think it won’t be embedded. This
should probably exclude the known Ipy/Dlr assemblies from the GAC check.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+1 on what Jeff said as well, I’d just add an overload instead of doing the default value thing.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Now I’m going to have to think more about pyc support for PTVS.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
<a href="mailto:ironpython-users-bounces+dinov=microsoft.com@python.org" target="_blank">ironpython-users-bounces+dinov=microsoft.com@python.org</a>
<a href="mailto:[mailto:ironpython-users-bounces+dinov=microsoft.com@python.org]" target="_blank">
[mailto:ironpython-users-bounces+dinov=microsoft.com@python.org]</a> <b>On Behalf Of
</b>Slide<br>
<b>Sent:</b> Thursday, February 23, 2012 7:55 PM<br>
<b>To:</b> <a href="mailto:ironpython-users@python.org" target="_blank">ironpython-users@python.org</a><br>
<b>Subject:</b> [Ironpython-users] Patch<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Just wanted to get this out for review before I push it. I would have done it through my fork on github and issued a pull request, but my fork is currently messed up. Let me know if you see anything out of the ordinary.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Fixes 32288 and 26706<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">slide<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <br>
Website: <a href="http://earl-of-code.com" target="_blank">http://earl-of-code.com</a><u></u><u></u></p>
</div>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Website: <a href="http://earl-of-code.com" target="_blank">http://earl-of-code.com</a><br>