[Bug 796836] [NEW] Valid set commands are never detected as administrivia.

[Mark Sapiro]

Public bug reported:

The is_administrivia function in Mailman/Utils.py requires a 'set'
command to have exactly three arguments and further requires that the
second argument be 'on' or 'off' in order to be detected as
administrivia. This means that none of the following valid commands are
detected.

    set help
    set show [address=<address>]
    set authenticate <password> [address=<address>]
    set<keyword> on
    set <keyword> off
    set digest plain
    set digest mime

Unless the command is

    set authenticate <password> address=<address>

and the password is 'on' or 'off', however a line such as

    set that off topic

would be detected as administrivia even though it is not.

Clearly the intent was to require two arguments, not three, but even
this would not detect things like

    set help

or

    set digest plain

The obvious fix is to require between one and two (or maybe three)
arguments and to not require the second argument to be 'on' or 'off',
but this may wind up giving too many false positives. This bug has
existed since the format of the set command was changed in Mailman 2.1,
and I'm not aware of any complaints about 'set' not being caught as
administrivia, so I'm reluctant to 'rock the boat' too much. Does anyone
have an opinion on this?

** Affects: mailman
     Importance: Low
     Assignee: Mark Sapiro (msapiro)
         Status: New

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/796836

Title:
  Valid set commands are never detected as administrivia.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/796836/+subscriptions