[Mailman-Developers] A couple of possible fixes to Mailman 2.1.9

[Lindsay Haisley]

These are a few things I found while debugging my Mailman installation
after the Gentoo mailman ebuild maintainer brought PREFIX and VAR_PREFIX
in line with the Linux standard FSH.  The changes are
distribution-neutral but fix a couple of issues that crop up when
PREFIX != VAR_PREFIX.

check_perms_grsecurity.py is a contrib piece, but should be patched as
follows:

@@ -132,8 +132,8 @@
     print file
 
     print "\nEnsuring that all config.db/pck files are owned by Mailman"
-    cdbs = glob.glob(paths.prefix + '/lists/*/config.db*')
-    cpcks = glob.glob(paths.prefix + '/lists/*/config.pck*')
+    cdbs = glob.glob(paths.var_prefix + '/lists/*/config.db*')
+    cpcks = glob.glob(paths.var_prefix + '/lists/*/config.pck*')
 
     for file in cdbs + cpcks:
         stat = os.stat(file)


var_prefix isn't defined in paths.py, but probably should be.  Adding:

var_prefix = 'whatever ...'

after line 31 in paths.py takes care of this, and var_prefix can be set
by the autoconf/configure process in the install.


~mailman/bin/update may need to be patched as follows:

@@ -344,7 +344,7 @@
     # a new one there
     #
     tmpl_dir = os.path.join(mm_cfg.PREFIX, "templates")
-    list_dir = os.path.join(mm_cfg.PREFIX, "lists")
+    list_dir = os.path.join(mm_cfg.VAR_PREFIX, "lists")
     b4_tmpl_dir = os.path.join(tmpl_dir, mlist._internal_name)
     new_tmpl_dir = os.path.join(list_dir, mlist._internal_name)
     if os.path.exists(b4_tmpl_dir):

I may be out to lunch on this one, but it got my attention.  Does the
use of PREFIX for the lists directory here apply to a legacy version of
Mailman ("pre-b4")?  If so, then perhaps this isn't an error.

-- 
Lindsay Haisley       | "Everything works    |     PGP public key
FMP Computer Services |       if you let it" |      available at
512-259-1190          |    (The Roadie)      | http://pubkeys.fmp.com
http://www.fmp.com    |                      |