<div dir="ltr">Congratulations!!<div><br></div><div>I have been waiting for a long time to see a nanmean function inside numpy.</div><div>I never looked inside this function, but I'm happy seeing this discussion on github!</div>
<div><br></div><div>Cheers,</div><div>Arnaldo.</div><div><br></div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div><div><div><font face="arial, sans-serif" size="4"><br>
</font></div><div><font face="arial, sans-serif" size="1" color="#cccccc"><span style="border-collapse:collapse"><span style="font-family:arial;font-size:small;border-collapse:separate"><span style="border-collapse:collapse;font-family:arial,sans-serif;background-color:rgb(255,255,255)"><font size="1">---<br>
<b>Arnaldo D'Amaral Pereira Granja Russo</b><br>Lab. de Estudos dos Oceanos e Clima</font></span><div><span style="border-collapse:collapse;font-family:arial,sans-serif;background-color:rgb(255,255,255)"><font size="1">Instituto de Oceanografia - FURG<br>
<br><br></font></span></div></span></span></font></div></div></div></div>
<br><br><div class="gmail_quote">2013/8/10 Ralf Gommers <span dir="ltr"><<a href="mailto:ralf.gommers@gmail.com" target="_blank">ralf.gommers@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Sat, Aug 10, 2013 at 12:48 AM, David Reed <span dir="ltr"><<a href="mailto:david.reed.c@gmail.com" target="_blank">david.reed.c@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><span style="background-color:rgba(255,255,255,0)">Hello,</span><div><span style="background-color:rgba(255,255,255,0)"><br>
</span></div><div><span style="background-color:rgba(255,255,255,0)">This is my first time contributing and I was hoping to get a review of a change I made. Here is the comparison link.</span></div><div><span style="background-color:rgba(255,255,255,0)"><br>
</span></div><div><a href="https://github.com/dvreed77/numpy/compare/nanmean" style="background-color:rgba(255,255,255,0)" target="_blank"><font color="#000000">https://github.com/dvreed77/numpy/compare/nanmean</font></a></div>
</div></div></blockquote><div><br></div></div></div><div>Hi David, your contribution looks good and adding nanmean is a good idea. However, your code happens to overlap for almost 100% with an already submitted pull request: <a href="https://github.com/numpy/numpy/pull/3534" target="_blank">https://github.com/numpy/numpy/pull/3534</a>. I suggest that you compare your implementation with the one in PR-3534, and maybe you can add an example there or fix some inconsistency.<br>
<br></div><div>This doesn't seem all that consistent by the way. The PR doesn't have an example, so I don't know if it behaves the same:<br></div><div><br><table><tbody><tr>
<td> >>> np.nanmean([1, np.nan, np.inf])
</td>
</tr>
<tr>
<td>
inf
</td>
</tr>
<tr>
<td></td>
</tr>
<tr>
<td></td>
</tr>
<tr>
<td>
>>> np.nanmean([1, np.nan, np.inf, np.NINF])
</td>
</tr>
<tr>
<td>
nan
</td></tr></tbody></table><br></div></div>Cheers,<br>Ralf<br><br></div></div>
<br>_______________________________________________<br>
NumPy-Discussion mailing list<br>
<a href="mailto:NumPy-Discussion@scipy.org">NumPy-Discussion@scipy.org</a><br>
<a href="http://mail.scipy.org/mailman/listinfo/numpy-discussion" target="_blank">http://mail.scipy.org/mailman/listinfo/numpy-discussion</a><br>
<br></blockquote></div><br></div>