<div dir="ltr"><div><div>I don't have CFLAGS defined. But I have iothers env variable that point to other python stuff like CPATH.<br><br></div>But even in that case, I don't understand how other people could have compiled methods.c. The include aren't part of the env variable, but in the file.<br>
<br></div><div>Anyway, I think your PR is the good fix. I checked our PR and now I have this new error:<br><br>gcc: numpy/core/src/multiarray/multiarraymodule.c<br><br>In file included from numpy/core/src/multiarray/multiarraymodule.c:3753:0:<br>
<br>build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:303:18: error: ‘PyArray_Partition’ undeclared here (not in a function)<br><br>build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:304:18: error: ‘PyArray_ArgPartition’ undeclared here (not in a function)<br>
<br>In file included from numpy/core/src/multiarray/multiarraymodule.c:3753:0:<br><br>build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:303:18: error: ‘PyArray_Partition’ undeclared here (not in a function)<br>
<br>build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:304:18: error: ‘PyArray_ArgPartition’ undeclared here (not in a function)<br><br>error: Command "gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -O2 -fPIC -DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c numpy/core/src/multiarray/multiarraymodule.c -o build/temp.linux-x86_64-2.7/numpy/core/src/multiarray/multiarraymodule.o" failed with exit status 1<br>
<br><br></div><div>So it seam we have the same problem with those 2 functions. They are defined in numpy/core/src/multiarray/item_selection.c, but not in the .h file.<br></div><div><br></div><div>thanks<br></div><div><div>
<br>Fred<br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 9, 2013 at 11:44 AM, Charles R Harris <span dir="ltr"><<a href="mailto:charlesr.harris@gmail.com" target="_blank">charlesr.harris@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Mon, Sep 9, 2013 at 9:33 AM, Frédéric Bastien <span dir="ltr"><<a href="mailto:nouiz@nouiz.org" target="_blank">nouiz@nouiz.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>I tried it and retried and it still fail. This is in an virtualenv<br></div><div><br>$git show<br>
commit c9b06111227f7a4ec213571f97e1b8d19b9c23f5<br>Merge: 73fbfb2 8edccea<br>Author: Charles Harris <<a href="mailto:charlesr.harris@gmail.com" target="_blank">charlesr.harris@gmail.com</a>><br>
Date: Sun Sep 8 19:47:21 2013 -0700<br><br> Merge pull request #3701 from cgohlke/patch-2<br> <br> ENH: add support for Python 3.4 ast.NameConstant<br><br><br><br></div>$rm -rf build ## Fail as there is no such directory<br>
</div><div>$pip install . # fail with the same error<br><br></div><div>$pip uninstall numpy<br></div><div>$python setup.py install --user # fail with the same error<br></div><div>$pip install . ## fail with the same error:<br>
<br>$git grep PyArray_SelectkindConverter<br></div><div>doc/release/1.8.0-notes.rst:* PyArray_SelectkindConverter<br>numpy/core/code_generators/numpy_api.py: 'PyArray_SelectkindConverter': 298,<br>numpy/core/src/multiarray/conversion_utils.c:PyArray_SelectkindConverter(PyObject *obj, NPY_SELECTKIND *selectkind)<br>
numpy/core/src/multiarray/methods.c: PyArray_SelectkindConverter, &sortkind,<br>numpy/core/src/multiarray/methods.c: PyArray_SelectkindConverter, &sortkind,<br>
<br><br></div><div>Here I don't see PyArray_SelectkindConverter in conversion_utils.h as you said it is present. Witch commit do you use?<br><br></div></div></blockquote><div><br></div></div><div>It's not there, it is part of the API. I've got a PR to add it to the *.h file. The question is why you are the only person (so far) to have a problem compiling. What are your CFLAGS?<br>
<br></div><div>Chuck <br></div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Fred<br></div><div><br></div></div><div class="gmail_extra">
<br><br>
<div class="gmail_quote"><div><div>
On Mon, Sep 9, 2013 at 11:02 AM, Charles R Harris <span dir="ltr"><<a href="mailto:charlesr.harris@gmail.com" target="_blank">charlesr.harris@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Mon, Sep 9, 2013 at 8:51 AM, Charles R Harris <span dir="ltr"><<a href="mailto:charlesr.harris@gmail.com" target="_blank">charlesr.harris@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Mon, Sep 9, 2013 at 7:46 AM, Frédéric Bastien <span dir="ltr"><<a href="mailto:nouiz@nouiz.org" target="_blank">nouiz@nouiz.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi,<br><br>I checkout the dev version of numpy and it fail to compile with this error:<br><br>
creating build/temp.linux-x86_64-2.7/build/src.linux-x86_64-2.7/numpy/core/src/multiarray<br><br>compile options: '-DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c'<br>
<br>gcc: numpy/core/src/multiarray/sequence.c<br><br>gcc: numpy/core/src/multiarray/descriptor.c<br><br>gcc: numpy/core/src/multiarray/getset.c<br><br>gcc: numpy/core/src/multiarray/arrayobject.c<br><br>gcc: numpy/core/src/multiarray/methods.c<br>
<br>numpy/core/src/multiarray/methods.c: In function ‘array_partition’:<br><br>numpy/core/src/multiarray/methods.c:1199:38: error: ‘PyArray_SelectkindConverter’ undeclared (first use in this function)<br><br>numpy/core/src/multiarray/methods.c:1199:38: note: each undeclared identifier is reported only once for each function it appears in<br>
<br>numpy/core/src/multiarray/methods.c: In function ‘array_argpartition’:<br><br>numpy/core/src/multiarray/methods.c:1316:38: error: ‘PyArray_SelectkindConverter’ undeclared (first use in this function)<br><br>numpy/core/src/multiarray/methods.c:1352:9: warning: assignment makes pointer from integer without a cast<br>
<br>numpy/core/src/multiarray/methods.c: In function ‘array_partition’:<br><br>numpy/core/src/multiarray/methods.c:1199:38: error: ‘PyArray_SelectkindConverter’ undeclared (first use in this function)<br><br>numpy/core/src/multiarray/methods.c:1199:38: note: each undeclared identifier is reported only once for each function it appears in<br>
<br>numpy/core/src/multiarray/methods.c: In function ‘array_argpartition’:<br><br>numpy/core/src/multiarray/methods.c:1316:38: error: ‘PyArray_SelectkindConverter’ undeclared (first use in this function)<br><br>numpy/core/src/multiarray/methods.c:1352:9: warning: assignment makes pointer from integer without a cast<br>
<br>error: Command "gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -O2 -fPIC -DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c numpy/core/src/multiarray/methods.c -o build/temp.linux-x86_64-2.7/numpy/core/src/multiarray/methods.o" failed with exit status 1<br>
<br><br></div> PyArray_SelectkindConverter is defined in numpy/core/src/multiarray/conversion_utils.c. methods.c include conversion_utils.h, but there is no fct declaration of this fct in this file. Is that normal?<br><br>
</div></div></blockquote><div><br></div></div><div>No, it looks like a bug. What is strange is that it doesn't show up on my machine. What compiler flags are you using?<br><br></div><div>Could you make a PR for this?<br>
<br>
</div><div><snip><br></div><div><br></div></div></div></div></blockquote><div><br></div></div></div><div>Wait a minute, it is in the API. Try a clean build and see what happens.<br><br></div><div>Chuck <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><br></div></div></div></blockquote></div></div></div>
<br></div></div><div>_______________________________________________<br>
NumPy-Discussion mailing list<br>
<a href="mailto:NumPy-Discussion@scipy.org" target="_blank">NumPy-Discussion@scipy.org</a><br>
<a href="http://mail.scipy.org/mailman/listinfo/numpy-discussion" target="_blank">http://mail.scipy.org/mailman/listinfo/numpy-discussion</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
NumPy-Discussion mailing list<br>
<a href="mailto:NumPy-Discussion@scipy.org" target="_blank">NumPy-Discussion@scipy.org</a><br>
<a href="http://mail.scipy.org/mailman/listinfo/numpy-discussion" target="_blank">http://mail.scipy.org/mailman/listinfo/numpy-discussion</a><br>
<br></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
NumPy-Discussion mailing list<br>
<a href="mailto:NumPy-Discussion@scipy.org">NumPy-Discussion@scipy.org</a><br>
<a href="http://mail.scipy.org/mailman/listinfo/numpy-discussion" target="_blank">http://mail.scipy.org/mailman/listinfo/numpy-discussion</a><br>
<br></blockquote></div><br></div>