<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">OK. So I am in the midst of a pull request adding a “maxlag” mode to correlate (<a href="https://github.com/numpy/numpy/compare/master...bringingheavendown:maxlag" class="">https://github.com/numpy/numpy/compare/master...bringingheavendown:maxlag</a>). Am I to understand that I no longer need to preserve the old_behavior functionality? Is it possible that we could address my pull request and then remove the old_behavior functionality because now my pull request is unmergeable.<div class="">Honi<br class=""><div class=""><div class="">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Jun 20, 2015, at 5:32 PM, Nathaniel Smith <<a href="mailto:njs@pobox.com" class="">njs@pobox.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">On Jun 20, 2015 1:43 PM, "Charles R Harris" <<a href="mailto:charlesr.harris@gmail.com" class="">charlesr.harris@gmail.com</a>> wrote:<br class="">
><br class="">
> Hi All,<br class="">
><br class="">
> There are three long ago deprecations that I am not sure how to handle.<br class="">
><br class="">
> keywords skiprows and missing in genfromtxt, deprecated in 1.5.<br class="">
> keyword old_behavior (default False) in correlate. added in 1.5 at least, but default value changed later.<br class="">
><br class="">
> The documentation says they will be removed in numpy 2.0, but we might want to try ealier. The case of the correlation function is trickier, as we probabaly need to provide a function with the old behavior before removing the keyword.</p><p dir="ltr" class="">Wouldn't this function just be<br class="">
correlate(a, conj(b))<br class="">
? Surely just writing that is easier and clearer than any function call we could provide.</p><p dir="ltr" class="">> I've left these cases as is, but the more old stuff hanging about the greater our technical debt.</p><p dir="ltr" class="">I guess we could try dropping them from the first release candidate and at least get some data on whether anyone notices.</p><p dir="ltr" class="">1.5 was a lonnnng time ago.</p><p dir="ltr" class="">-n</p>
_______________________________________________<br class="">NumPy-Discussion mailing list<br class=""><a href="mailto:NumPy-Discussion@scipy.org" class="">NumPy-Discussion@scipy.org</a><br class="">http://mail.scipy.org/mailman/listinfo/numpy-discussion<br class=""></div></blockquote></div><br class=""></div></div></body></html>