<div dir="ltr">On Fri, Mar 9, 2018 at 2:29 AM, Nathaniel Smith <span dir="ltr"><<a href="mailto:njs@pobox.com" target="_blank">njs@pobox.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Mar 8, 2018 at 7:06 AM, Marten van Kerkwijk<br>
<<a href="mailto:m.h.vankerkwijk@gmail.com">m.h.vankerkwijk@gmail.com</a>> wrote:<br>
> A larger comment: you state that you think `np.asanyarray` is a<br>
> mistake since `np.matrix` and `np.ma.MaskedArray` would pass through<br>
> and that those do not strictly mimic `NDArray`. Here, I agree with<br>
> `matrix` (but since we're deprecating it, let's remove that from the<br>
> discussion), but I do not see how your proposed interface would not<br>
> let `MaskedArray` pass through, nor really that one would necessarily<br>
> want that.<br>
<br>
</span>We can discuss whether MaskedArray should be an AbstractArray.<br>
Conceptually it probably should be; I think that was a goal of the<br>
MaskedArray authors (even if they wouldn't have put it that way). In<br>
practice there are a lot of funny quirks in MaskedArray, so I'd want<br>
to look more carefully in case there are weird incompatibilities that<br>
would cause problems. Note that we can figure this out after the NEP<br>
is finished, too.<br>
<br>
I wonder if the matplotlib folks have any thoughts on this? I know<br>
they're one of the more prominent libraries that tries to handle both<br>
regular and masked arrays, so maybe they could comment on how often<br>
they run</blockquote><div><br></div><div>There's a lot of places in matplotlib where this could simplify our checks, though probably more from a standpoint of "does this thing we've been given need converting?"</div><div><br></div><div>There are also a lot of places where matplotlib needs to know if we have actually been given a MaskedArray so that we can handle it specially.</div><div><br></div><div>Ryan </div><div><br></div><div>-- </div></div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Ryan May<br><br></div></div></div>
</div></div>