[Patches] Please review before applying
Fri, 21 Apr 2000 23:50:39 +0200
Guido van Rossum wrote:
> Wanted: reviews for this patch! It seems usable but (as the author
> admits) needs another careful eye before I can apply it.
I begun skimming over it and stumbled here:
--- 236,242 ----
elif requestline[-1:] == '\n':
requestline = requestline[:-1]
self.requestline = requestline
! words = requestline.split()
if len(words) == 3:
[command, path, version] = words
if version[:5] != 'HTTP/':
Shouldn't we be consequent and use the new startswith methods
as well, instead of if version[:5] != 'HTTP/' ?
I think it would be better to do this all in one big shot.
ciao - chris
Christian Tismer :^) <mailto:firstname.lastname@example.org>
Applied Biometrics GmbH : Have a break! Take a ride on Python's
Kaunstr. 26 : *Starship* http://starship.python.net
14163 Berlin : PGP key -> http://wwwkeys.pgp.net
PGP Fingerprint E182 71C7 1A9D 66E9 9D15 D3CC D4D7 93E2 1FAE F6DF
where do you want to jump today? http://www.stackless.com