[Patches] Fix compiler warning in posixmodule.c
Fred L. Drake, Jr.
Wed, 1 Mar 2000 14:47:33 -0500 (EST)
Greg Ward writes:
> Second patch attached -- this is relative to the original code, not to
> my first patch. This one's cleaner, as it defines USE_CTERMID_R and
> USE_TMPNAM_R up at the top of the file, so the preprocessor logic deep
> in the guts is simple: "#ifdef USE_CTERMID_R". Is the "USE_XXX"
> terminology OK? What about the placement of these two #define's (after
> all the other conditional #define's at the top of the file)?
I suppose that's OK, but I don't like having to add new #defines
that have to be chased down. Since there's only three sites that use
the two different tests, "just do it" seems to make more sense.