[Patches] [ python-Patches-1372125 ] fix UnixBrowswer failure when no browser running

[SourceForge.net]

Patches item #1372125, was opened at 2005-12-02 18:04
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1372125&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Greg Couch (gregcouch)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix UnixBrowswer failure when no browser running

Initial Comment:
See discussions in bug #1352621 and bug #1338995 for
even more details.

Background:

The webbrowser.py was modified, post-Python 2.4.2, to
tell whether or not the browser invocation succeeded or
not.  Unfortunately, the modifications caused Python
applications to hang when no browser was already
present.    And the reputed fix for bug #1338995,
revision 41419, only made things worse for UnixBrowsers.

Fix:

The changes to webbrowser.py were well intentioned, but
failed because it was difficult to tell if invocation
succeeded due to an extra level of indirection in
invoking the browser by using os.system().

The attached patch, for revision 41511, uses
subprocess.Popen() instead for UnixBrowser.  The other
uses of os.system() would also benefit, but are less
critical to me.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1372125&group_id=5470