[Patches] [ python-Patches-1005895 ] curses for win32

[SourceForge.net]

Patches item #1005895, was opened at 2004-08-09 03:05
Message generated for change (Comment added) made by jlt63
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1005895&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modules
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Alexandr Zamaraev (shura_zam)
Assigned to: Jason Tishler (jlt63)
Summary: curses for win32

Initial Comment:
I have paths for compile _curses module.
I use 
compiler - mingw32 v3.3.1
curses library - Public Domain Curses (PDCurses 2.6)

----------------------------------------------------------------------

>Comment By: Jason Tishler (jlt63)
Date: 2005-06-16 07:28

Message:
Logged In: YES 
user_id=86216

If the patch affects Cygwin, then it's not obvious:

$ fgrep -i cygwin _cursesmodule.c.patch mingw32.mak 
test_curses.py.patch
$

However, it seems to affect the native Windows build:

$ grep -i 'platform.*win' _cursesmodule.c.patch mingw32.mak 
test_curses.py.patch 
test_curses.py.patch:+ if sys.platform == 'win32':

Please point out actually where the patch affects Cygwin.
Thanks.

----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2005-06-16 06:02

Message:
Logged In: YES 
user_id=11375

As maintainer of the curses module, applying the patch is OK
with me, but I'm not going to apply it because I don't use
Cygwin, the affected platform.  I leave it up to you to
apply the patch, or reject it, or demand changes; I'm happy
if you decide to apply it, but don't really care.  

(Note that the patch to test_curses.py won't apply cleanly;
it includes some other fixes from Alexandr that I've already
applied.  If you decide to accept the patch, I can help
straighten out test_curses.py.)



----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2005-06-16 05:48

Message:
Logged In: YES 
user_id=86216

> I have no access to a Windows machine and no way
> to test them or the new .mak file, so I'm
> reassigning this bug to Jason Tishler, who does a
> lot of Cygwin work.  Jason, please feel free to
> ask me any questions you might have about curses,
> the _cursesmodule.c file, or whatever.

Andrew,

Sorry, but I'm confused.  What exactly are you
asking me to do?  Make sure Alexandr's patch
doesn't break the Cygwin build?  Other builds?
Works?

Thanks,
Jason

----------------------------------------------------------------------

Comment By: Alexandr Zamaraev (shura_zam)
Date: 2005-06-15 20:45

Message:
Logged In: YES 
user_id=980085

>In the cursesmodule patch, the first argument to intrflush
>is changed from NULL to stdscr.  Why?
In PDCurses intrflush return ERR if first arg is NULL.

>In the setting of _C_API_VERSION, what does the string
>"PDCurses M" mean?  (In particular, what does the 'M' stand
for?)
_C_API_VERSION setting to numeric constant PDC_BUILD
currentli 2601.
Bat _C_API_NAME setting to name of C curses library.
I modyfy source of PDCurses and add suffix "M".
Currently all my changes applay in head branch, 
and suffix "M" not nidded. ;-)


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2005-06-15 11:20

Message:
Logged In: YES 
user_id=11375

In the cursesmodule patch, the first argument to intrflush
is changed from NULL to stdscr.  Why?  According to the
ncurses man page, the window argument is ignored.

use_env() is apparently a no-op for PDcurses; why not just
remove the Python-visible use_env function completely? 

In the setting of _C_API_VERSION, what does the string
"PDCurses M" mean?  (In particular, what does the 'M' stand
for?)

Except for the above questions, the patches to
test_curses.py and _cursesmodule.c look OK.  I have no
access to a Windows machine and no way to test them or the
new .mak file, so I'm reassigning this bug to Jason Tishler,
who does a lot of Cygwin work.  Jason, please feel free to
ask me any questions you might have about curses, the
_cursesmodule.c file, or whatever.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1005895&group_id=5470