[Patches] [ python-Patches-1472257 ] pdb: fix for #1472251('run/runeval' commands bug)

[SourceForge.net]

Patches item #1472257, was opened at 2006-04-18 05:22
Message generated for change (Comment added) made by isandler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1472257&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 3
Submitted By: Kuba Kończyk (jakamkon)
Assigned to: Nobody/Anonymous (nobody)
Summary: pdb: fix for #1472251('run/runeval' commands bug)

Initial Comment:
This simple patch ensure that the first argument to the
'run/runeval' functions is string.See Bug #1472251 for
more details.

----------------------------------------------------------------------

Comment By: Ilya Sandler (isandler)
Date: 2006-06-25 09:25

Message:
Logged In: YES 
user_id=971153

...1.Why?bdb.py prints informations about breakpoints to
stdout in bpprint function....

I am not sure printing to stdout in bpprint was a good
decision! Really, if bdb is intended to be a low-level
debugging module, it should not print anything to stdout...

..I included new patch.What's your opinion?...

A couple of comments:
 1) the latest pdb's output goes through redirection. The
patch does not..
 2) Is it really necessary to restrict pdb's run() to
strings? Being able to pass a code object seems like a
useful thing (I know that pdb docs explicitly say that the
1st arg must be a string)
 3) finally, I guess I am not sure about the general
approach to argument type checking in stdlib. 
(is it really pdb's business to check run() arguments? E.g
if bdb's run() supports other types (say, UserString or
file), pdb's type checking would have to change)...


I guess, I am  -0 on this patch..

----------------------------------------------------------------------

Comment By: Kuba Kończyk (jakamkon)
Date: 2006-06-19 07:44

Message:
Logged In: YES 
user_id=1491175

1.Why?bdb.py prints informations about breakpoints to stdout
in bpprint function.

2.This is correct.Comment right before run function should
be updated to point that bdb.py's run could be used also
with code objects.

According to the pdb's documentation, run command should be
invoked only with statement given as a string.Run's argument
checking and error message could be placed in pdb's run
function.I included new patch.What's your opinion?


----------------------------------------------------------------------

Comment By: Ilya Sandler (isandler)
Date: 2006-06-18 15:07

Message:
Logged In: YES 
user_id=971153

I am not sure whether the original bug  is indeed a bug.
(see discussion of that bug)...

And even if #1472251 is deemed a bug, the patch has a couple
of unrelated problems:

1. bdb.py should not print anything on stdout

2. current bdb.py's run() accepts code objects, the patch
breaks it.

Should the patch be rejected?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1472257&group_id=5470