[Patches] [ python-Patches-1514544 ] mailbox: use fsync() to ensure data is really on disk

[SourceForge.net]

Patches item #1514544, was opened at 2006-06-29 14:27
Message generated for change (Comment added) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1514544&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: David Watson (baikie)
Assigned to: A.M. Kuchling (akuchling)
Summary: mailbox: use fsync() to ensure data is really on disk

Initial Comment:
The mailbox module currently does nothing to ensure
messages/indexes are physically on disk when the
flush() method returns or message files are closed. 
This patch adds functions _sync_flush and _sync_close
to flush and fsync() a file object, and in the latter
case close it afterwards.  _sync_close is then used
where needed throughout the code.  (For various reasons
the current implementation only ever requires a sync
immediately before closing a file, but _sync_flush is
provided for future use.)


----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2006-11-09 08:55

Message:
Logged In: YES 
user_id=11375

I've tweaked the top comment in the patch a little and
applied it to the trunk in rev. 52692 (so it'll be in 2.6).

Because it's an internal API change, I'm cautious about
applying it to the 25-maint branch, but will raise the issue
on python-dev.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1514544&group_id=5470