[pypy-svn] r50733 - pypy/build/buildbot

[exarkun at codespeak.net]

Author: exarkun
Date: Thu Jan 17 21:57:59 2008
New Revision: 50733

Modified:
   pypy/build/buildbot/pypy_status.py
Log:
trivial visual improvements

  * something one might mistake for part of a legend
  * better ordering of build results (I guess)



Modified: pypy/build/buildbot/pypy_status.py
==============================================================================
--- pypy/build/buildbot/pypy_status.py	(original)
+++ pypy/build/buildbot/pypy_status.py	Thu Jan 17 21:57:59 2008
@@ -25,6 +25,8 @@
         builderNames = status.getBuilderNames()
 	failedTests = {}
 
+	buildNumbers = range(self.oldBuildCount - 1, -1, -1)
+
         for name in builderNames:
             recentFailures = Set()
             builder = status.getBuilder(name)
@@ -57,21 +59,30 @@
                         testName,
                         tags.span(style="background-color: cyan;")['?'])
 
-        table = tags.table()
+        testResultsTable = tags.table()
         heading = tags.tr()
-        for buildNumber in range(self.oldBuildCount):
+        for buildNumber in buildNumbers:
             heading[tags.td()[buildNumber]]
-        table[heading]
+        heading[tags.td()["<- How many builds ago"]]
+        testResultsTable[heading]
 
         for testName in recentFailures:
             row = tags.tr()
-            for buildNumber in range(self.oldBuildCount):
+            for buildNumber in buildNumbers:
                 result = []
                 for builderName in builderNames:
                     key = (builderName, buildNumber, testName)
                     result.append(failedTests[key])
                 row[tags.td()[result]]
             row[tags.td()[testName]]
-            table[row]
+            testResultsTable[row]
 
-        return flatten(table)
+        legend = tags.div[
+            tags.div()["P - Passed"],
+            tags.div()["F - Failed"],
+            tags.div()["S - Skipped"],
+            tags.div()["? - No result available"]]
+
+        return flatten(tags.div()[
+            legend,
+            testResultsTable])