[pypy-svn] r74095 - pypy/branch/blackhole-improvement/pypy/jit/codewriter

[fijal at codespeak.net]

Author: fijal
Date: Tue Apr 27 04:58:45 2010
New Revision: 74095

Modified:
   pypy/branch/blackhole-improvement/pypy/jit/codewriter/flatten.py
Log:
Leave a comment. Also don't rely on whether operations is an empty tuple
or empty list


Modified: pypy/branch/blackhole-improvement/pypy/jit/codewriter/flatten.py
==============================================================================
--- pypy/branch/blackhole-improvement/pypy/jit/codewriter/flatten.py	(original)
+++ pypy/branch/blackhole-improvement/pypy/jit/codewriter/flatten.py	Tue Apr 27 04:58:45 2010
@@ -172,13 +172,17 @@
             self.make_link(block.exits[0])
             self.emitline(Label(block.exits[0]))
             for link in block.exits[1:]:
-                if (link.exitcase is Exception and link.target.operations == ()
+                if (link.exitcase is Exception and (not link.target.operations)
                     and len(link.target.inputargs) == 2):
                     # default exit-by-exception block
                     self.emitline("reraise")
                 else:
                     self.emitline('goto_if_exception_mismatch',
-                                  Constant(link.llexitcase), TLabel(link))
+                                  Constant(link.llexitcase),
+                                  # XXX should I live concretetype here
+                                  #     or should I just make user do
+                                  #     lltype.typeOf???
+                                  TLabel(link))
                     self.make_link(link)
                     self.emitline(Label(link))
         else: