[pypy-commit] pypy refactor-buffer-api: comments

bdkearns noreply at buildbot.pypy.org
Thu Apr 24 01:03:27 CEST 2014


Author: Brian Kearns <bdkearns at gmail.com>
Branch: refactor-buffer-api
Changeset: r70898:8f8a5ff1a59a
Date: 2014-04-23 19:02 -0400
http://bitbucket.org/pypy/pypy/changeset/8f8a5ff1a59a/

Log:	comments

diff --git a/pypy/interpreter/baseobjspace.py b/pypy/interpreter/baseobjspace.py
--- a/pypy/interpreter/baseobjspace.py
+++ b/pypy/interpreter/baseobjspace.py
@@ -1364,6 +1364,7 @@
                                  self.wrap('cannot convert negative integer '
                                            'to unsigned int'))
 
+    # XXX define these flags correctly, possibly put elsewhere?
     BUF_SIMPLE = 0
     BUF_FULL_RO = 1
     BUF_CONTIG = 2
@@ -1401,6 +1402,7 @@
             raise oefmt(self.w_TypeError,
                         "expected a character buffer object")
 
+    # XXX rename these/replace with code more like CPython getargs for buffers
     def bufferstr_w(self, w_obj):
         # Directly returns an interp-level str.  Note that if w_obj is a
         # unicode string, this is different from str_w(buffer(w_obj)):


More information about the pypy-commit mailing list