[pypy-dev] Re: Recent Checkins

[Michael Hudson]

roccomoretti at netscape.net (Rocco Moretti) writes:

> First off, mea culpa.
>
> I'm not sure how unpardonable a sin this is, but I now realize that my 
> recent checkins make the test_all.py script fail. This (probably) isn't as 
> bad as it sounds. Firstly, it works fine for the trivial object space - it 
> only has problems with StdObjSpace. Secondly, it's only one file that has 
> problems (test_exec.py), and it seems that the problems were there before 
> the checkin, it was just that the unittest wasn't picking them up. (It was 
> running at interpreter level, not at application level as it should be - 
> and no surprise here; CPython handles the exec statement perfectly :)
>
> I'd try to fix the errors, but they seem to be complex, and not directly 
> due to the EXEC_STMT opcode - as I said, TrivialObjSpace passes.

Can you drop into IRC?  #pypy on irc.openproject.net.  I'm not doing
much right now, we can try and fix this.

Or maybe you have already?  I don't see any failures.

> You can run test_all for yourself on revision 839+, but here is a synopsis 
> of the errors:
>
> * The StdObjSpace dictionary does not have a "has_key" function attribute.
> * You get a "Type Error: an integer is required" when executing a code 
>     object. This error message occurs twice in the standard obj space
>     [objspace.py, concretespace.py], and an unknown number of times in
>     CPython.
> - We need more specific error messages.
> * An exception within an exec statement does not bubble up to the caller.
> - AppTestCase needs more specific messages with self.AssertRaises calls. -
>     Currently it only gives a blank AssertionError (with no message).

I have changes for this that need polishing.  As they're on my peecee
and not my laptop, it would probably be a good idea if I checked them
in before leaving :-)

Cheers,
M.

-- 
  For every complex problem, there is a solution that is simple,
  neat, and wrong.                                    -- H. L. Mencken