<br><br><div class="gmail_quote">On Tue, May 3, 2011 at 10:30 AM, Armin Rigo <span dir="ltr"><<a href="mailto:arigo@tunes.org">arigo@tunes.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi,<br>
<div class="im"><br>
On Tue, May 3, 2011 at 1:20 PM, Maciej Fijalkowski <<a href="mailto:fijall@gmail.com">fijall@gmail.com</a>> wrote:<br>
> Sorry it took so long to review, long weekend and whatnot. The test<br>
> for x86 backend actually fails for -1.0 on 64bit. Can you<br>
> reproduce/deny?<br>
<br>
</div>I fixed it, it was really a bug about FINISH(ConstFloat(...)). But<br>
the patch, at least as applied now, does not have the intended effect;<br>
SQRTSD is never generated because ll_math_sqrt() is called with a<br>
residual call. Joe, can you fix it? I can try to if you don't have<br>
the time.<br>
<br>
<br>
A bientôt,<br>
<font color="#888888"><br>
Armin.<br>
</font><div><div></div><div class="h5">_______________________________________________<br>
<a href="mailto:pypy-dev@codespeak.net">pypy-dev@codespeak.net</a><br>
<a href="http://codespeak.net/mailman/listinfo/pypy-dev" target="_blank">http://codespeak.net/mailman/listinfo/pypy-dev</a><br>
</div></div></blockquote></div><br>Another thing is it would be useful to test that the SQRTSD is generated, I don't know a good way to do that though.<div><br></div><div>Alex<br clear="all"><br>-- <br>"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)<br>
"The people's good is the highest law." -- Cicero<br><br>
</div>