Amaury,<br><br><div class="gmail_quote">On Sun, Aug 21, 2011 at 2:20 PM, Amaury Forgeot d'Arc <span dir="ltr"><<a href="mailto:amauryfa@gmail.com">amauryfa@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hello,<br><br><div class="gmail_quote"><div class="im">2011/8/21 Mitchell Hashimoto <span dir="ltr"><<a href="mailto:mitchell.hashimoto@gmail.com" target="_blank">mitchell.hashimoto@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>I noticed the 'os' module is incomplete, and I'd like to help complete this.</div></blockquote><div><br></div></div><div>You are very welcome!</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>CPython does this by simply having these methods available on "posix" "nt" "os2" etc. and the "os" module imports those. It appears that PyPy does the same thing. I was able to successfully add 'getlogin' as practice, but I wanted to post here before going further. Some questions below:</div>
<div><br></div><div>1.) Should I mimic CPython and add the functionality to the OS-specific modules?</div></blockquote><div><br></div></div><div>Yes we should mimic CPython: fortunately these modules have different names but share the same source file.</div>
<div>With CPython it's Modules/posixmodule.c, with PyPy it's in pypy/module/posix.</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>2.) I don't have a Windows computer on hand. What is the standard practice for implementing some stdlib for one OS but not the other? Would PyPy accept this temporarily?</div>
</blockquote><div><br></div></div><div>Yes, no problem. In this case, I think it's best to let the test fail on Windows so that someone may notice and fix it.</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>3.) There are many missing methods, to simplify implementation time and the patch, would it be okay to submit a patch for each stdlib method, so that this was built up over time?</div></blockquote><div><br></div></div>
<div>
Yes, smaller patches are easier to read and merge. I'd be happy to review and commit them. </div></div></blockquote><div><br></div><div>Great! Thanks for the response :)</div><div><br></div><div>I'll post the patch in an issue for each stdlib method as I make it, and I'll just post here to ask for review.</div>
<div><br></div><div>Thanks,</div><div>Mitchell</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><br></div>-- <br><font color="#888888">Amaury Forgeot d'Arc<br>
</font></blockquote></div><br>