<html style="direction: ltr;">
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<style type="text/css">body p { margin-bottom: 0cm; margin-top: 0pt; } </style>
</head>
<body style="direction: ltr;"
bidimailui-detected-decoding-type="latin-charset" bgcolor="#FFFFFF"
text="#000000">
I have begun running own tests on win32.<br>
<a class="moz-txt-link-freetext" href="http://buildbot.pypy.org/summary?builder=own-win-x86-32">http://buildbot.pypy.org/summary?builder=own-win-x86-32</a><br>
Almost all of the module._cffi_backend.test.test_c failures are
caused by id(x) returning a long where an int is expected in
rlib\objectmodel.py compute_unique_id. Note that this passes after
translation on applevel tests, so it seems there is a difference
between the non-translated and translated versions of
compute_unique_id which AFAIK returns a lltype.Signed .<br>
<br>
would this fix be acceptable? On which platforms does
compute_unique_id return a r_longlong ?<br>
Matti<br>
<br>
--- a/rpython/rlib/objectmodel.py Sun Mar 09 23:17:48 2014
+0200<br>
+++ b/rpython/rlib/objectmodel.py Mon Mar 10 00:32:41 2014
+0200<br>
@@ -432,6 +432,10 @@<br>
costly depending on the garbage collector. To remind you of
this<br>
fact, we don't support id(x) directly.<br>
"""<br>
+ v = id(x)<br>
+ if sys.platform == 'win32':<br>
+ from rpython.rlib.rarithmetic import intmask<br>
+ v = intmask(v)<br>
return id(x) # XXX need to return r_longlong on some
platforms<br>
<br>
def current_object_addr_as_int(x):<br>
<br>
<br>
</body>
</html>