On Tue, Jul 1, 2008 at 1:53 PM, Georg Brandl <<a href="mailto:g.brandl@gmx.net">g.brandl@gmx.net</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Fred Drake schrieb:<div class="Ih2E3d"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Jul 1, 2008, at 4:28 PM, Georg Brandl wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
While I'm opposed to sweeping stdlib refactorings, this is an<br>
exception because a) the urllib package was only recently created,<br>
</blockquote>
<br>
I'm not objecting to a refactoring; that would work just fine for the new package.<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
b) the imports are from other urllib submodules and therefore<br>
should be easy to understand and c) it mirrors what was done<br>
in urllib2.py.<br>
</blockquote>
<br>
What I am objecting to is the assertion that importing names directly into the global namespace for a module is in any way "cleaner". That's a style issue, and I don't think there's anything approximating consensus on the matter.<br>
</blockquote>
<br></div>
OK, cleaner is perhaps the wrong word, forgive me for badly expressing<br>
myself :) What I meant is what I tried to explain in point b) -- since<br>
the imported names all refer to urllib-specific things, they do not<br>
cause confusion if you come across them unadorned in the source.<font color="#888888"><br></font></blockquote></div><br>For comparison, the Google style guide for Python code specifically forbids this particular style, motivated by making it clearer where things come from.<br clear="all">
<br>-- <br>--Guido van Rossum (home page: <a href="http://www.python.org/~guido/">http://www.python.org/~guido/</a>)