<div dir="ltr"><br><br><div class="gmail_quote">On Sat, Jul 19, 2008 at 1:00 AM, Jesus Cea <<a href="mailto:jcea@jcea.es">jcea@jcea.es</a>> wrote: <br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Anybody is able to compile current bsddb in 3.0 svn?. May I overwrite<br>
current version with my own one, updated with your patches (except the<br>
buffer code; I rather prefer to delay that)?.<br>
</blockquote><div><br>Yes, feel free to replace it with your updated code. py3k bsddb has largely been neglected so far.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
This lib is huge and fairly complex for a binding. The testsuite has<br>
more than 300 testcases, and growing. Keeping an unified codebase (for<br>
python 2.x and 3.0) seems to be the only way to garantee quality and<br>
avoid divergence. I'm asking for module ownership, to be able to meet<br>
3.0 deadline with an stable and complete product. For example, current<br>
3.0 code has no replication or distributed transactions support, while<br>
2.6 has.<br>
<br>
So I'm asking your permission to:<br>
<br>
1. Take your (valuable) current patches in 3.0.<br>
<br>
2. Replace current code with my own one + your patches. The Buffer<br>
protocol will be out at this time. It will be evaluated when the binding<br>
is ready for 3.0. Time constrains and my aim to keep an unified codebase<br>
precludes its inclusion, *for now*. This will change in the future, of<br>
course.<br>
<br>
3. The canonical sourcecode would be the 2.6 version. The C code in 3.0<br>
should be identical. The Python code in 3.0 would be a direct<br>
translation via 2to3. So, patches should go to 2.6. I will keep 2.6 and<br>
3.0 in sync.</blockquote><div><br>I agree with all of the above. the existing py3k branch bsddb code should be tossed out and replaced by your unified 2.6+3.0 code base. Thanks for examining it to extract whatever potentially useful changes are already in it.<br>
<br>The py3k bsddb module buffer protocol work was done in large part by me last year as an attempt at using the buffer protocol (some changes to the buffer protocol resulted). I think its okay if the bsddb module isn't using it even in the 3.0 release, it can happen for 3.1.<br>
<br>-gps<br><br></div></div><br></div>