[ python-Bugs-1178141 ] urllib.py overwrite HTTPError code with 200

[SourceForge.net]

Bugs item #1178141, was opened at 2005-04-06 18:48
Message generated for change (Comment added) made by jimjjewett
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1178141&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.3
Status: Pending
Resolution: None
Priority: 5
Submitted By: Barry Alan Scott (barry-scott)
Assigned to: Nobody/Anonymous (nobody)
Summary: urllib.py overwrite HTTPError code with 200

Initial Comment:
I found this bug while trying to understand why a 404
Not Found error was reported as a 200 Not Found.

Turns out the HTTPError's self.code is overwritten with
200 after
the 404 was correctly assigned.

The attached patch fixes the problem.


----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-02-20 16:53

Message:
Logged In: YES 
user_id=764593

Barry -- Are you sure that the original status code wasn't 
204?  If so, then this patch makes more sense.

Georg -- any unrecognized response status NXX should be 
treated as N00.  Since 204 (and 298, for that matter) aren't 
recognized by the urllib opener, they should be treated as 
200, which the patch does.  

Whether the patch makes it harder to treat 204 separately 
when it is recognized is another issue.


----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2006-02-20 16:30

Message:
Logged In: YES 
user_id=849994

I cannot see the point of the patch and cannot reproduce the
error.

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2005-04-08 12:18

Message:
Logged In: YES 
user_id=764593

Please reattach (SF didn't catch the file)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1178141&group_id=5470