[issue1657] [patch] select.epoll wrapper for Linux 2.6 epoll()
report at bugs.python.org
Wed Dec 19 10:47:30 CET 2007
Thomas Herve added the comment:
Cool, thanks for working on that. Just for the record, I don't really
understand the workflow: why closing the other ticket as duplicate and
not post the patch on the old one? But whatever.
For this patch, I don't see the benefit of putting it in the select
module, instead of a separate module. Is there a specific reason?
Looking at the code, I don't have many remarks. pyepoll_new may leak if
epoll_create fails. I think that allowing threading around epoll_ctl is
useless, but I may be wrong.
Thanks again for working on it.
Tracker <report at bugs.python.org>
More information about the Python-bugs-list