[ python-Bugs-1569622 ] Backward incompatibility in logging.py

[SourceForge.net]

Bugs item #1569622, was opened at 2006-10-02 23:10
Message generated for change (Comment added) made by vsajip
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1569622&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.5
>Status: Closed
Resolution: Fixed
Priority: 9
Private: No
Submitted By: Mike Klaas (mklaas)
Assigned to: Neal Norwitz (nnorwitz)
Summary: Backward incompatibility in logging.py 

Initial Comment:
LogRecord.__init__ changed in a backward incompatible
way in python 2.5 (added one parameter).  

There is no mention of this breakage in the release
notes, nor has the documentation of the module been
updated (http://docs.python.org/lib/node424.html)

----------------------------------------------------------------------

>Comment By: Vinay Sajip (vsajip)
Date: 2007-01-08 10:13

Message:
Logged In: YES 
user_id=308438
Originator: NO

Done. I'm not sure what you're getting at with those revision numbers -
trunk and branches/release25-maint are now up to date; if you think other
branches need to be updated, please name those branches explicitly.

----------------------------------------------------------------------

Comment By: Mike Klaas (mklaas)
Date: 2007-01-08 02:19

Message:
Logged In: YES 
user_id=1611720
Originator: YES

This fix should be back-ported to 2.5 maint:

r52100,52101,52102

perhaps also r52555,52556?

----------------------------------------------------------------------

Comment By: Vinay Sajip (vsajip)
Date: 2006-10-03 18:22

Message:
Logged In: YES 
user_id=308438

Documentation now updated in CVS. Also changed the added
"func" parameter to have a default value of None.

Sorry for the inconvenience caused.

----------------------------------------------------------------------

Comment By: Mike Klaas (mklaas)
Date: 2006-10-03 17:14

Message:
Logged In: YES 
user_id=1611720

It is incompatible as code written for 2.4 will break in
2.5, and vice-versa (this is a required parameter, not an
optional parameter, and the change could have been made in a
backward-compatible way).

You're right that the documentation fix is the important thing.



----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2006-10-03 06:11

Message:
Logged In: YES 
user_id=849994

I don't see why adding one parameter is backwards
incompatible, but it's true that the docs must be updated.
Assigning to Vinay.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1569622&group_id=5470