[issue3547] Ctypes is confused by bitfields of varying integer types

[Thomas Heller]

Thomas Heller <theller at ctypes.org> added the comment:

Fredrik Lundh schrieb:
> Looks fine to me, except for the comment in the test suite.  Should
> 
> +        # MS compilers do NOT combine c_short and c_int into
> +        # one field, gcc doesn't.
> 
> perhaps be
> 
> +        # MS compilers do NOT combine c_short and c_int into
> +        # one field, gcc do.

Sure.  But isn't this correct (or better) english, instead?

                            ^^^^

> Is using explicit tests for MSVC vs. GCC a good idea, btw?  What about 
> other compilers?  Can the test be changed to accept either value?

Well, MSVC and GCC are the only compilers that I use (and that are tested
on the buildbots, afaik).  If a cygwin compiled Python, for example, fails
this test then of course the test must be changed.

Thanks.

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3547>
_______________________________________