[issue5170] logging to file + encoding

Wed Apr 22 10:47:38 CEST 2009

shamilbi <shamilbi at gmail.com> added the comment:

>
> Trunk and release26-maint were recently changed (r71657, r71658) to use
> the following logic, which differs from the code snippet you posted.
>
>                    if (isinstance(msg, unicode) and
>                        getattr(stream, 'encoding', None)):
>                        stream.write(fs.decode(stream.encoding) % msg)
>                     else:
>                        stream.write(fs % msg)
>
> If the stream is stderr and you are passing a unicode msg, the else
> branch will not be taken; as long as the stream has an encoding
> attribute, it should output correctly.
>
> The change was made when another, similar issue was posted by another
> user (issue #5768).
>
> Can you confirm what happens with the current code as it is in
> release26-maint? ÑÐ¿Ð°ÑÐ¸Ð±Ð¾!

it still doesn't work for console (but OK for files).

the following works in both cases:
if (isinstance(msg, unicode) and
    getattr(stream, 'encoding', None) and
    (stream == sys.stdout or stream == sys.stderr)):
    stream.write(fs % msg.encode(stream.encoding))
else:
     stream.write(fs % msg)

i think it's all about the difference betwin print(msg) and
sys.stdout.write('%s\n' % msg)

shamil

----------
Added file: http://bugs.python.org/file13734/unnamed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5170>
_______________________________________
-------------- next part --------------
<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Trunk and release26-maint were recently changed (r71657, r71658) to use<br>

the following logic, which differs from the code snippet you posted. 
 
 Â  Â  Â  Â  Â  Â  Â  Â  Â  Â if (isinstance(msg, unicode) and 
 Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â getattr(stream, &#39;encoding&#39;, None)): 
 Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â stream.write(fs.decode(stream.encoding) % msg) 
<div class="im"> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â else: 
 Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â stream.write(fs % msg) 
 
</div>If the stream is stderr and you are passing a unicode msg, the else 
branch will not be taken; as long as the stream has an encoding 
attribute, it should output correctly. 
 
The change was made when another, similar issue was posted by another 
user (issue #5768). 
 
Can you confirm what happens with the current code as it is in 
release26-maint? ÑÐ¿Ð°ÑÐ¸Ð±Ð¾!</blockquote><div>Â </div></div>it still doesn&#39;t work for console (but OK for files). the following works in both cases: if (isinstance(msg, unicode) and 
 Â Â Â  getattr(stream, &#39;encoding&#39;, None) and Â Â Â  (stream == sys.stdout or stream == sys.stderr)): Â Â Â  stream.write(fs % msg.encode(stream.encoding)) else: Â Â Â Â  stream.write(fs % msg) i think it&#39;s all about the difference betwin print(msg) and sys.stdout.write(&#39;%s\n&#39; % msg) 
 shamil