[issue4850] Change type and add _Py_ prefix to COUNT_ALLOCS variables

Martin v. Löwis report at bugs.python.org
Wed Jan 7 19:43:08 CET 2009


Martin v. Löwis <martin at v.loewis.de> added the comment:

> My main interest in this patch are the type and %d to %zd change, but
> by throwing in the name change, I unintentionally made it more
> controversial.   Would it help if I resubmit the patch without name
> changes or is this something that a committer can take care of if the
> patch is partially accepted?

I think it is indeed better to focus on this part of the patch only.

I just reviewed it, and I think it is incorrect: We cannot assume that
the CRT supports %zd, therefore, PY_FORMAT_SIZE_T has to be used.

I fixed it, and removed the _Py_ prefixing, and committed the result
as r68381.

> Also a grep through nm output that Marc-Andre did is a good check to
> run from time to time and there is no reason to have false positives.

make smelly

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue4850>
_______________________________________


More information about the Python-bugs-list mailing list