[issue4972] let's equip ftplib.FTP with __enter__ and __exit__
report at bugs.python.org
Wed Jan 21 03:27:52 CET 2009
Alexander Belopolsky <belopolsky at users.sourceforge.net> added the comment:
Please remove the old smtplib.patch: it is confusing to have two
attachments with the same name. It will still be available in the
history, so nothing will be lost.
A nit-pick: 221 is a success code (in smtp 2xx codes are successes and
5xx are errors IIRC), so vars should be simply 'code' (or 'rc' for
return code) and 'msg', not 'errcode' and 'errmsg'.
Your new code may leave socket open in the case when self.docmd("quit")
raises an exception other than SMTPServerDisconnected.
BTW, I think your code will be simpler if you don't reuse quit() and
simply call docmd("quit") and close()directly in an appropriate
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list