[issue5872] New C API for declaring Python types
report at bugs.python.org
Thu Oct 29 12:34:08 CET 2009
Antoine Pitrou <pitrou at free.fr> added the comment:
This patch is huge.
- you should provide an example of using the new API. Your description
is not very, well, descriptive :)
- "all PyTypeObjects must now be *pointers* rather than static
instances": is it mandatory, or did you add this out of "purity"? It
would be nice if we could minimize disruption (that is, provide the new
API as a feature, but not force ourselves and other people to rewrite
huge chunks of code)
- same for the private declaration of PyTypeObject: is it really
necessary to hide it from outside code?
Lastly, since your patch is not ready for consumption, I would advocate
creating a branch somewhere (on the SVN sandbox if you have access
rights, or in a separate e.g. bitbucket repository by cloning the
existing Mercurial mirror).
nosy: +nnorwitz, pitrou
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list