[issue4932] Little improvement on urlparse module, urlparse function.
Senthil Kumaran
report at bugs.python.org
Wed Jul 14 13:57:30 CEST 2010
Senthil Kumaran <orsenthil at gmail.com> added the comment:
I reviewed the patch and we may not go with it.
- There is recent improvements in parsing and the patch does not go well with it, especially the clear_cache removal.
Also there is a mistake in the patch:
- scheme, url = url[:i].lower(), url[i+1:]
+ url = url[i+1:]
This can create problems for certain parsing logic as scheme is being used later in the code.
Closing the bug is invalid.
----------
resolution: -> invalid
stage: unit test needed -> committed/rejected
status: open -> closed
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue4932>
_______________________________________
More information about the Python-bugs-list
mailing list