[issue9189] Improve CFLAGS handling

[Ronald Oussoren]

Ronald Oussoren <ronaldoussoren at mac.com> added the comment:

On 9 Jul, 2010, at 20:55, Jeffrey Yasskin wrote:

> 
> Jeffrey Yasskin <jyasskin at gmail.com> added the comment:
> 
> Oops. Thanks for telling me. Fixed in r82753.

I'm pretty sure this patch broke universal builds on OSX. Not the python build itself, but building 3th-party extensions. I'll commit a fix later on.

In the Makefile:

LDSHARED=       $(CC) $(LDFLAGS) -bundle -undefined dynamic_lookup

'gcc'
>>> sysconfig.get_config_var('LDFLAGS')
'-arch i386 -arch ppc -arch x86_64 -isysroot /'
>>> sysconfig.get_config_var('LDSHARED')
'gcc  -bundle -undefined dynamic_lookup'

That is, the LDFLAGS aren't patched into the value of LDSHARED. 

This is because LDFLAGS is actually PY_LDFLAGS in the makefile and the rename from PY_LDFLAGS to LDFLAGS happens *after* variable expansion in sysconfig.

This doesn't affect the build of python itself because the Makefile explictly sets LDFLAGS in the environment when running setup.py.

Ronald

----------
Added file: http://bugs.python.org/file18062/smime.p7s

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9189>
_______________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3567 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-bugs-list/attachments/20100719/4b20b82f/attachment-0001.bin>