[issue10311] Signal handlers must preserve errno

Hallvard B Furuseth report at bugs.python.org
Thu Nov 4 13:51:51 CET 2010


Hallvard B Furuseth <h.b.furuseth at usit.uio.no> added the comment:

Parser/intrcheck.c:intcatcher() should do the same.  Covered in Issue
10312.

Antoine Pitrou writes:
> This is a good idea IMO. It would be better if you minimized style
> changes, so that the patch is easier to review.

I'm afraid the un-rearranged code would be fairly ugly, so I cleaned
up first.  Single exit point.

> Also, is the while loop around write() necessary here?

Whoops, I'd forgotten I did that too, it was on my TODO list to
check if Python makes it unnecessary by making write restartable.
I don't remember if that's possible to ensure on all modern Posixes

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10311>
_______________________________________


More information about the Python-bugs-list mailing list