[issue12009] netrc module crashes if netrc file has comment lines
R. David Murray
report at bugs.python.org
Fri Jun 10 11:40:52 CEST 2011
R. David Murray <rdmurray at bitdance.com> added the comment:
lexer.instream.readline(): no, we can't just call that without the seek, because reading the token that started with # may have caused the line to be consumed already. I've expanded the comment to explain this.
cygwin: I'd add a comment if I knew what that was for. This was copied from the existing tests.
order of assertEqual args: this reversed style was the existing style in the test file, but since we are doing a full refactor anyway I've consistently reversed them in the updated patch.
Should I apply these to the current branches (including 3.1) or is it easier for you to do it in your release clones? If you do it, note that the test patch doesn't apply cleanly to 3.x, but that's only because of a couple of PEP8ifications (a space was removed from between the name and the '(' in a couple function calls in 3.x), which should be easy enough to adjust by hand in order to apply the patch.
Added file: http://bugs.python.org/file22313/netrc-comment-fix.patch
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list