[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Antoine Pitrou
report at bugs.python.org
Fri Jun 10 18:57:33 CEST 2011
Antoine Pitrou <pitrou at free.fr> added the comment:
Good idea, and thanks for posting a patch! This is a new feature, so 3.3-only. Also, you'll need to update the docs (Doc/library/zlib.rst, presumably) to add the new module method/attribute (with a suitable "versionadded" tag).
Nitpicking:
- "zlibVersion" isn't PEP8-compliant
- semantically it should probably be a module-level attribute, rather than a method; after all it's kind of a constant; perhaps ZLIB_RUNTIME_VERSION?
Also, I see that ZLIB_VERSION itself isn't documented, it would be nice to have a separate patch to fix that.
----------
nosy: +pitrou
stage: -> patch review
versions: -Python 2.7, Python 3.2
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12306>
_______________________________________
More information about the Python-bugs-list
mailing list