[issue11572] bring Lib/copy.py to 100% coverage

Éric Araujo report at bugs.python.org
Sat Mar 19 14:36:44 CET 2011


Éric Araujo <merwok at netwok.org> added the comment:

Nice cleanup.

-            reductor = getattr(x, "__reduce__", None)
-            if reductor:
-                rv = reductor()
-            else:
-                raise Error("un(shallow)copyable object of type %s" % cls)
+            raise Error("un(shallow)copyable object of type %s" % cls)
Why change this?

>         self.assertTrue(issubclass(copy.Error, Exception))
You could change that to assertIsInstance.

> -def _test():
I assume that all cases that were tested in that function are covered by unit tests.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11572>
_______________________________________


More information about the Python-bugs-list mailing list