[issue7652] Merge C version of decimal into py3k.
report at bugs.python.org
Wed Mar 7 14:49:45 CET 2012
Stefan Krah <stefan-usenet at bytereef.org> added the comment:
Antoine Pitrou <report at bugs.python.org> wrote:
> You could use Py_LOCAL_INLINE, but most compilers should inline small
> functions automatically, AFAIK.
At the time I wrote it I benchmarked everything. I'm pretty sure
that gcc did not inline larger functions like mpd_qresize_zero()
and mpd_word_digits() and even some smaller ones that are declared
ALWAYS_INLINE. Also, the static inline functions in the header
files are absolutely crucial for speed.
I recall that Mark initially said that in the Modules hierarchy
not every module would need to compile. Now, _decimal is already
tested with gcc, clang, icc, suncc, Visual Studio, and success
has been reported with xlc. CompCert compiles libmpdec but not
_ctypes does not compile with icc and suncc. Unlike _ctypes, _decimal
has a fallback in the form of decimal.py. So, perhaps as an alternative
we could leave the inlines and wait for build failure reports?
 compilation success, one of the numerous AIX issues on
bugs.python.org with loading the module was encountered IIRC.
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list