[issue11959] smtpd cannot be used without affecting global state

Vinay Sajip report at bugs.python.org
Thu Mar 15 13:14:54 CET 2012


Vinay Sajip <vinay_sajip at yahoo.co.uk> added the comment:

> I notice that your logging test code doesn't override create_socket.  Is that no longer needed?

I removed that code from test_logging, but the code in the BitBucket repo shows how I'd like smtpd to be changed.

I would of course prefer to avoid copying stuff from SMTPChannel, as the docstring for TestSMTPChannel indicates. If you could take a look at the suggested changes in

https://bitbucket.org/vinay.sajip/cpython-smtpd/compare/default..mirror/cpython

and let me have your comments, that'd be great. The code in that repo does redefine create_socket.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11959>
_______________________________________


More information about the Python-bugs-list mailing list