[issue14565] is_cgi doesn't function as documented for cgi_directories
report at bugs.python.org
Mon May 7 23:15:36 CEST 2012
Glenn Linderman <v+python at g.nevcal.com> added the comment:
You are right, the "found" variable is not needed, I guess the reason I coded it that way, is I had some validation code before the return, during testing, so it was easier not to have it in three places.
Regarding precalculating ln, I don't know how Python is coded internally, so it seems that string compares could be lengthier integer compares, and even in your code the length is calculated sometimes. So it is mostly an order of operations optimization... I didn't attempt to benchmark it with various URL and cgi_directories values, including at least both some with large prefix matches, and some without... I didn't figure it would matter much, but if you think it does, then feel free to benchmark.
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list