<div dir="ltr"><div dir="ltr"><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">Requiring Travis to pass</span></blockquote><div style="font-size:12.8px"> </div><span style="font-size:12.8px">Yes please.</span><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <span style="font-size:12.8px">Cherry-picking working out?</span></blockquote><div style="font-size:12.8px">Works for me. And I've done a lot of this :)</div><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">are the labels for cherry-picking working out?</span></blockquote><div style="font-size:12.8px">I like the [3.6] Prefix (Thanks Berker for suggesting it originally)</div><div style="font-size:12.8px">I think [cherry-pick for 3.6] label is still useful as a visual cue in the GitHub Web UI, but it does create extra work for core devs to apply the labels. Perhaps won't be an issue once the cherry-pick bot is in place?</div><div style="font-size:12.8px">Anyway, I think we should keep both :)</div><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">Is the mention </span>bot<span style="font-size:12.8px"> helpful?</span><br></blockquote><div style="font-size:12.8px">I think if we can reduce the number of reviewers from 5 to 3 or 2, it might reduce the amount of spam people are getting? </div><div style="font-size:12.8px">When someone starts blacklisting themselves from the mention-bot, it just means that another person will now get spammed, and then decided to blacklist themselves too. </div><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">anything I missed?</span></blockquote><div style="font-size:12.8px">I'm wishing for an easy way to differentiate/identify PRs where:</div><div style="font-size:12.8px">- It's been reviewed, changes were requested, but author has not responded/made updates. --> so don't bother reviewing</div><div style="font-size:12.8px">- It's been reviewed, changes were requested, and author has updated the PR. --> so it's ready for another look</div><div style="font-size:12.8px">At the moment, both of these scenarios are shown as "Changes Requested" in GitHub web UI. It's hard to determine whether it's time to re-review the PR or not.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Maybe we can add [wip] in the title after we requested the change. Once PR author made further changes, they can remove the [wip]. </div><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">Right now, cherry-picking is very annoying but I'm not sure that<br></span><span style="font-size:12.8px">merging would be much better with the PR requirement. I'm looking<br></span><span style="font-size:12.8px">forward to automation!</span></blockquote><div style="font-size:12.8px"><div> </div>I have a semi-automated command line script here: <a href="https://github.com/mariatta/chic_a_cherry_picker">https://github.com/mariatta/chic_a_cherry_picker</a></div><div style="font-size:12.8px">Please try it out :) I've cherry-picked quite a number of commits with this.</div><div style="font-size:12.8px">Works well when you don't anticipate any merge conflicts :)</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">The command line is something like:</div><div style="font-size:12.8px">$ python -m cherry_picker some-commit-sha1 3.6 3.5</div><div style="font-size:12.8px">It will do the cherry-pick and opens up web browser for creating the PR, with head and base branches preselected.</div><div style="font-size:12.8px">All you need to do is enter [3.5] or [3.6] in the description, and press the shiny green 'Create Pull Request' button.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Related: here's a list of merged PRs that need backporting to 3.6</div><div><span style="font-size:12.8px"><a href="https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr%20label%3A%22needs%20backport%20to%203.6%22%20is%3Amerged%20">https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr%20label%3A%22needs%20backport%20to%203.6%22%20is%3Amerged%20</a></span><br></div><div><span style="font-size:12.8px"><br></span></div><div style="font-size:12.8px"><br></div><blockquote class="gmail_quote" style="font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px">Overall, I'm positive on the move. Thanks for continuing to shepherd<br></span><span style="font-size:12.8px">the migration, Brett!</span></blockquote><div style="font-size:12.8px">+1.Thanks!</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px"><br></div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">Mariatta Wijaya</div></div>
<br><div class="gmail_quote">On Sat, Mar 11, 2017 at 8:05 AM, Donald Stufft <span dir="ltr"><<a href="mailto:donald@stufft.io" target="_blank">donald@stufft.io</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class=""><br><div><blockquote type="cite"><div>On Mar 11, 2017, at 3:03 AM, Zachary Ware <<a href="mailto:zachary.ware+pydev@gmail.com" target="_blank">zachary.ware+pydev@gmail.com</a>> wrote:</div><br class="m_-4061086899520446777Apple-interchange-newline"><div><blockquote type="cite" style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br class="m_-4061086899520446777Apple-interchange-newline">Is the mention bot helpful? (Our config is at<br><a href="https://github.com/python/cpython/blob/master/.mention-bot" target="_blank">https://github.com/python/<wbr>cpython/blob/master/.mention-<wbr>bot</a><span class="m_-4061086899520446777Apple-converted-space"> </span>and the docs are<br>at<span class="m_-4061086899520446777Apple-converted-space"> </span><a href="https://github.com/facebook/mention-bot" target="_blank">https://github.com/<wbr>facebook/mention-bot</a>)<br></blockquote><br style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">I think so, it has prompted me to give a quick review on a couple of</span><br style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">PRs. It is occasionally annoying, but it's not hard to ignore. I can</span><br style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">see how it would be *very* annoying for anyone who has touched large</span><br style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">swaths of the codebase, though. If there's a way to make it opt-in,</span><br style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:OperatorMono-Book;font-size:11px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">perhaps we could give that a spin?</span></div></blockquote></div><br><div><br class="m_-4061086899520446777webkit-block-placeholder"></div></span><div>There’s no way to make it opt-in except by having people explicitly list what files they want to be notified on (either on an always basis, or on a “if you couldn’t find enough people through your heuristics” basis).</div><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><br>—<span class="HOEnZb"><font color="#888888"><br>Donald Stufft<br></font></span></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><br></div><br class="m_-4061086899520446777Apple-interchange-newline">
</div>
<br></div><br>______________________________<wbr>_________________<br>
python-committers mailing list<br>
<a href="mailto:python-committers@python.org">python-committers@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/python-committers" rel="noreferrer" target="_blank">https://mail.python.org/<wbr>mailman/listinfo/python-<wbr>committers</a><br>
Code of Conduct: <a href="https://www.python.org/psf/codeofconduct/" rel="noreferrer" target="_blank">https://www.python.org/psf/<wbr>codeofconduct/</a><br></blockquote></div><br></div>