<div dir="ltr">"View Changes" doesn't work when commits in PR were squashed, which seems to be the case in <a href="https://github.com/python/cpython/pull/851" rel="noreferrer" style="font-size:12.8px" target="_blank">https://github.com/python/c<wbr>python/pull/851</a><div><br></div><div><div>I wonder if there is a way to unsquash the commits? Will it help with reviewing this PR?</div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">Mariatta Wijaya</div></div>
<br><div class="gmail_quote">On Tue, Apr 11, 2017 at 2:55 AM, Donald Stufft <span dir="ltr"><<a href="mailto:donald@stufft.io" target="_blank">donald@stufft.io</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>If someone makes a review on github (as opposed to a simple comment) I believe the state of the code as it was when that review as made can be viewed by hitting the “View Changes” button next to that review in the timeline.</div><br><div><blockquote type="cite"><div><div class="h5"><div>On Apr 10, 2017, at 3:18 PM, Guido van Rossum <<a href="mailto:guido@python.org" target="_blank">guido@python.org</a>> wrote:</div><br class="m_929389577765148049Apple-interchange-newline"></div></div><div><div><div class="h5"><div dir="ltr">Thanks for the clarification. We should probably move this discussion to the python-committers list rather than core-mentorship.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 10, 2017 at 12:12 PM, Terry Reedy <span dir="ltr"><<a href="mailto:tjreedy@udel.edu" target="_blank">tjreedy@udel.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 4/10/2017 12:54 PM, Guido van Rossum wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So the response from Martin Panter<br>
(<a href="https://github.com/python/cpython/pull/851#issuecomment-292755992" rel="noreferrer" target="_blank">https://github.com/python/cpy<wbr>thon/pull/851#issuecomment-292<wbr>755992</a>)<br>
sounds like he's not set up for the new GitHub workflow. I'm CC'ing<br>
Martin here.<br>
</blockquote>
<br></span>
The specific issue Martin raised is "Sorry but I don’t have an easy way to see your fixes relative to the old version I reviewed." If the original and modified patches were posted in proper format to b.p.o., then one could hit [review] to start Rietveld and request a side-by-side diff of the two versions. This is perfect for reviewing responses to comments, especially those made in-line. For this issue, Martin made about 20 inline comments.<br>
<br>
I don't see any way to get the equivalent on a github PR. It appears that the original patch is replaced by the revised patch. To me, Rietveld was a great review tool and its loss a regression in the work process. I hope that this can be fixed somehow.<br>
<br>
tjr<div class="m_929389577765148049HOEnZb"><div class="m_929389577765148049h5"><br>
<br>
<br>
______________________________<wbr>_________________<br>
Core-mentorship mailing list<br>
<a href="mailto:Core-mentorship@python.org" target="_blank">Core-mentorship@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/core-mentorship" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/listinfo/core-mentorship</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="m_929389577765148049gmail_signature" data-smartmail="gmail_signature">--Guido van Rossum (<a href="http://python.org/~guido" target="_blank">python.org/~guido</a>)</div>
</div></div></div>
______________________________<wbr>_________________<br>python-committers mailing list<br><a href="mailto:python-committers@python.org" target="_blank">python-committers@python.org</a><br><a href="https://mail.python.org/mailman/listinfo/python-committers" target="_blank">https://mail.python.org/<wbr>mailman/listinfo/python-<wbr>committers</a><br>Code of Conduct: <a href="https://www.python.org/psf/codeofconduct/" target="_blank">https://www.python.org/psf/<wbr>codeofconduct/</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><br>—<span class="HOEnZb"><font color="#888888"><br>Donald Stufft<br></font></span></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><br></div><br class="m_929389577765148049Apple-interchange-newline">
</div>
<br></div><br>______________________________<wbr>_________________<br>
python-committers mailing list<br>
<a href="mailto:python-committers@python.org">python-committers@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/python-committers" rel="noreferrer" target="_blank">https://mail.python.org/<wbr>mailman/listinfo/python-<wbr>committers</a><br>
Code of Conduct: <a href="https://www.python.org/psf/codeofconduct/" rel="noreferrer" target="_blank">https://www.python.org/psf/<wbr>codeofconduct/</a><br>
<br></blockquote></div><br></div>